Skip to content
OverviewSolutions
8
Comments
8
Manish
@manish2120

All comments

  • Manish•130
    @manish2120Posted 3 months ago

    Woah! The size looks perfect. However, there seems to be an issue with the quote icon SVG:

    • It looks like the size applied to the author's profile picture is also being applied to the SVG. It's better to use a separate class for the images and SVG where it differs.
    • The box-shadow is missing.
    • Avoid using px as it sets a fixed size for elements. Instead, use rem or em, whichever works best for you.
    0
  • Manish•130
    @manish2120Posted 4 months ago

    Niceee

    0
  • Manish•130
    @manish2120Posted 5 months ago

    Nice one!

    0
  • Manish•130
    @manish2120Posted 6 months ago

    I like the outcome of your project, but I think you should create a separate stylesheet because there is a lot of CSS included. Is that SCSS you’re using? I’ve never seen nested CSS before.

    0
  • Manish•130
    @manish2120Posted 6 months ago

    As i noticed : Regarding HTML

    • Semantics are missing.

    Regarding css

    • media queries are applied for mobile devices as per they mentioned in there for 375px ig.

    Overall its good, it quite looks similar :)

    0
  • Gobinath•140
    @gopinath-97Submitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    Done my third one for the day and used all my past learnings which I thought to forget, but with little of practice, all comes to place. Moving forward to build long single page sites.👩‍💻😊

    Social-Links-Preview

    2
    Manish•130
    @manish2120Posted 6 months ago

    • i don't know much about semantics, but you can also try using header and footer tag here frontend mentor let you know about the landmarks in there report after completing the project.

    • Overall its good 🙂, but yea media queries are missing and u can also try color finder extensions to get to know the color of cards as we know we dont have access of figma files after 2 projects so yea we can't make it same as per design 😓.

    0
  • Manish•130
    @manish2120Posted 6 months ago

    Did you follow the figma design? it will help you to get the desired output.

    Marked as helpful
    0
  • joyafrikaana•70
    @joyafrikaanaSubmitted 6 months ago
    What challenges did you encounter, and how did you overcome them?

    I learned about using the CSS flex property and media query. When I used the CSS flex property alongside fixed width, my project wasn't centered, but as soon as I removed the fixed width, my project became centered. Also, my mobile version was wonky even though my codes were right. I realised the problem was the order. I had placed the mobile media query before the tablet media query. The solution was to put the mobile media query before the tablet media query.

    What specific areas of your project would you like help with?

    I currently need help in understanding the relationship between css flex property and fixed width.

    Mobile-first solution using css flex property

    1
    Manish•130
    @manish2120Posted 6 months ago

    I'm not good in semantics or styling, but here are some points I’ve noticed hope its correct :) :

    Regarding HTML:

    1. You should use semantic tags like <main> and <footer> here to properly define your main content and content information.
    2. In your boilerplate code, it's better to place the `stylesheets before the closing </head> tag.

    Regarding CSS:

    1. Consider using min-height on the body or your container elements to ensure the minimum height of the parent element or body to covers the background and i guess it will help you here to center your content.
    2. Make sure to closely follow the Figma design. This will help you create an output that closely matches the design provided.

    Overall, nice work! By the way, it's nice to see that you used an <h1> tag and applied styling to it separately. I recently got to know about it that we should use heading tags according to their levels for semantic purpose.

    Marked as helpful
    0