@manish2120
Posted
I'm not good in semantics or styling, but here are some points I’ve noticed hope its correct :) :
Regarding HTML:
- You should use semantic tags like <main> and <footer> here to properly define your main content and content information.
- In your boilerplate code, it's better to place the `stylesheets before the closing
</head>tag.
Regarding CSS:
- Consider using min-height on the body or your container elements to ensure the minimum height of the parent element or body to covers the background and i guess it will help you here to center your content.
- Make sure to closely follow the Figma design. This will help you create an output that closely matches the design provided.
Overall, nice work! By the way, it's nice to see that you used an <h1> tag and applied styling to it separately. I recently got to know about it that we should use heading tags according to their levels for semantic purpose.
Marked as helpful
@joyafrikaana
Posted
Thanks, I recently understood the importance of semantic tags and I'd ensure I incorporate it henceforth. Also, thanks for the comment on min-height, it was quite helpful. @manish2120
@joyafrikaana
Posted
Thanks, I recently understood the importance of semantic tags and I'd ensure I incorporate it henceforth. Also, thanks for the comment on min-height, it was quite helpful. @manish2120
