P
@HelewudSubmitted 11 days ago
Latest comments
- @mandrisicPosted 4 days ago
it looks good but i just have few tips on how to improve this project:
- the overlay shouldn't just have a width od 32% it should go over other content except the open hambuger menu
- there is no need for 6 columns, 3 columns is the best option for your grid in this case, because i can see that the button 'Read more' and 02 section are not verticaly aligned -> and they would be if you put them in the same column (middle one)
Marked as helpful0 - @CLTJaredSubmitted 7 months ago@mandrisicPosted 9 days ago
looks good, could use more padding here and there but overall very nicely done
0 - @ilham-boukSubmitted 3 months agoWhat specific areas of your project would you like help with?
Any feedback are welcome
@mandrisicPosted 13 days agothe challenge was to make this task using only HTML and CSS, but in your code I saw you used JS as well. you should have used details and summary tags in html which would have made everything more accessible and easier for you to make. then you could also make the first summary item be open when the page loads so the user knows that they can open the other summaries as well.
0 - @zeeguSubmitted 27 days agoWhat are you most proud of, and what would you do differently next time?
❤Things I've tried
- Added
aria-label="Rate 1 out of 5"for better screen-reader support - Considered web accessibility
- Scored 99% on Google PageSpeed Insights
- Used Mobile first approach for responsive design
Please let me know if there are any areas of improvement! Thanks :D
@mandrisicPosted 17 days agowhen I previewed your code the font Overpass didn't load and in the mobile version the containers of each rating number was I guess too big because they went to another row -> maybe it's even because it's not the correct font. all in all screenshot looks great, so good job
0 - Added
- @shadowbanksSubmitted 20 days agoWhat specific areas of your project would you like help with?
I'm open to any other suggestions.
Thank you for your time :))
- P@kephaloskSubmitted 25 days agoWhat are you most proud of, and what would you do differently next time?
Building the html structure completelly in plain JavaScript without a framework.
What challenges did you encounter, and how did you overcome them?Dynamically rendering html elements by creating reusable components.
What specific areas of your project would you like help with?n/a
@mandrisicPosted 23 days agohello, I just threw a quick glance at your code and I have some things you could improve:
- you didn't use the font that was used in the design preview
- smallest mobile version 320px doesn't look good, it's not centered (probably because the container is too big)
- tablet version would look better if it also used the same design as the mobile version (everything in one column)
just practice and you'll se these things more clearly.
Marked as helpful1
