
Design comparison
Community feedback
- P@NatentadoPosted 23 days ago
Very nice implementation, i just have some tips for you. HTML: Try to have an alt text to all images you have across your application, for semantic and acessibility reasons. CSS: You can use the power of modern css features to have variables setted for the colors or styles you have across the app, and the nesting to reduce the amount of times @media size is called, last you could give the current time a white color to match the figma design. JS: You can store the value of the data.json once the first request is made, so every time a user change the period option it doesnt make another "api" call.
In general its a very good implementation, it works very well and looks incredibly nice. Nice job!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord