Skip to content
OverviewSolutions
5
Comments
10
Mako K
@makjnr317

All comments

  • Mako K•165
    @makjnr317Posted about 3 years ago

    Hie there. Your site isn't showing. looks like you gave wrong link

    0
  • Nicaisse•340
    @abanicaisseSubmitted about 3 years ago

    Hi, just completed the order summary card challenge but I got some little issues with the background image and the sizing of the card.

    Any suggestion would be very welcome !

    Order Summary with pure HTML and CSS

    1
    Mako K•165
    @makjnr317Posted about 3 years ago

    Hie there.

    • You used the wrong link for the background, you should use /images/pattern-background-mobile.svg
    • Also there is no need to add #main for everything in your CSS, it just makes coding more boring since you are repeating the same thing. Same as .main__description and .main__img, they do not need to be put on.
    • Instead of using #main in your CSS, you can still just say main
    0
  • Furkan•10
    @caspercerete31Submitted about 3 years ago

    I'm new to web design, I have questions for you. How can I improve my style of code, how can I improve the accessibility? Thank you for your answers

    Html/Css page using only HTML/CSS

    1
    Mako K•165
    @makjnr317Posted about 3 years ago

    Hie there. Just wanted to say your website isn't loading the CSS

    Marked as helpful
    0
  • Mako K•165
    @makjnr317Posted about 3 years ago

    Hie there. Just a tip. Try putting everything under <body> into one container the use flex to center it.

    Marked as helpful
    1
  • Mako K•165
    @makjnr317Posted about 3 years ago

    Hie there. Just a tip. Don't use margin to center <main> instead use flex. Also change the background for .containerText so that the whole page isn't blue. Besides that, most of the stuff is good.

    Marked as helpful
    0
  • Mako K•165
    @makjnr317Posted about 3 years ago

    Most of it looks a good, only a few things to note.

    • The text color on the Why Us section and part of the price section has to be changed as there is lack of contrast which makes it harder to read.
    • Add a background color to the body.
    • Add spread to the box-shadow so that it doesn't look almost as solid as a thin border.
    • When in mobile view don't make the component take the whole body width.
    Marked as helpful
    0
  • Mako K•165
    @makjnr317Posted about 3 years ago

    Most of the site looks good. Just a few thing that need changing.

    • After clicking an option on the dropdown or after clicking away from the dropdown, it should disapper.
    • Making selected theme stay even after reload or opening in new tab and even after closing the current tab and coming back to it.
    0
  • Mako K•165
    @makjnr317Posted about 3 years ago

    Some Tips

    • remove repeat from your background image
    • add a background color similar to that on the design
    • Use flex to make less use of margins and padding. It makes things easier

    Otherwise everything is okay

    1
  • genji21•140
    @genji21Submitted about 3 years ago

    Please feel free to give me any feedback help me to improve my code ! . Thanks

    Rest Country Api JS

    2
    Mako K•165
    @makjnr317Posted about 3 years ago

    Just a few tips for the inputs:

    • For the <select> it is usually better to make it yourself using <div> it becomes easier to change its appearance with CSS.
    • Use the the border property for the inputs

    For other stuff:

    • Make use of border-radius property
    0
  • Hairy Breeches•40
    @Hairy-BreechesSubmitted about 3 years ago

    Hello Guys! Its my first ever challenge that i have completed after learning HTML and CSS. I would really love some feedback on how it looks for a starter. Thanks in advance!

    Pure HTML and CSS

    1
    Mako K•165
    @makjnr317Posted about 3 years ago

    For a starter it looks okay considering that you did not use grids or flex. But, I'd suggest making use of flex to position your stuff and it will help you depend less use on margins and padding. It will also make it easier to center the Order-Summary-Component component compare to using the body padding.

    1