Design comparison
Solution retrospective
I'm new to web design, I have questions for you. How can I improve my style of code, how can I improve the accessibility? Thank you for your answers
Community feedback
- @makjnr317Posted about 3 years ago
Hie there. Just wanted to say your website isn't loading the CSS
Marked as helpful0@caspercerete31Posted about 3 years ago@makjnr317 Hi, How can I fix the problem? When I'm on the site it looks completely fine.
0@makjnr317Posted about 3 years ago@caspercerete31 ohhh i checked further.
The way you wrote your media queries means that for some devices such as my laptop, your site will be distorted e.g most of the styles for ".card" such as background color should not be put in @media, only the properties that change e.g "width" should be put in media queries .
- Also for the properties that change, you should provide a default value outside @media and that value should be for a particular screen width. Some people set it to the mobile width, personally i set it to my device's width.
Marked as helpful0@makjnr317Posted about 3 years ago@caspercerete31 check this "https://developer.chrome.com/docs/devtools/device-mode/". Then check for widths ranging from 500px to 1300px so you get what i mean
0@caspercerete31Posted about 3 years ago@makjnr317 I got it, thank you. In style-guide.md, it said set the width of the devices to 375px and 1440px. And so I did but I guess changing the background-color outside the media queries should fix the issue. Appreciate your help.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord