Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @Deeperr0

    Submitted

    What are you most proud of, and what would you do differently next time?

    I learned how to deal with cookies in JavaScript. I would add more comments next time

    What challenges did you encounter, and how did you overcome them?

    I had a problem with storing the cookies in a way that would be easily accessible and iterable. In the end decided to stick with a JSON object

    What specific areas of your project would you like help with?

    I would really appreciate some feedback regarding the clarity of my code and how can I write cleaner and more optimized code as in my opinion thats as clean and optimized as it can get.

    Lucas Cerri 1,120

    @llKryptonixll

    Posted

    First of all great work. I saw that you wrote :

    <img
        src="${
    			screenWidth > 768
    				? product.image.desktop
    				: screenWidth > 375
    				? product.image.tablet
    				: product.image.mobile
    	}"
        alt="${product.name}"
        class="product-image"
    />
    

    You dont need javascript to do it so leave the ternary and write it like this:

    <picture>
        <source srcset={desktop} media="(min-width: 1024px)" />
        <source srcset={tablet} media="(min-width: 768px)" />
        <img src={mobile} alt={name} />
    </picture>
    

    `

    `

    Marked as helpful

    0
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    Hey nice work, but I would also call the function after the page has loaded, so that a random advice can be seen after the page has loaded and not an empty area. window.addEventListener("load", getAdvice); Or just call the function without the load event.

    The HTML looks very good but i would replace:
    
    <div class="dice">
        <img src="./images/icon-dice.svg" alt="">
    </div>
    
    with:
    
    <button aria-label="Get random advice button">
        <img src="images/icon-dice.svg" alt="Dice Icon">
    </button>
    
    This is better for screenreaders and accessibility
    

    Marked as helpful

    0
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    Hey great work it looks good. To remove the unwanted horizontal scrollbar you can add margin: 0 to your body but for larger projects you might want to use a css reset. I also saw that your img has an empty alt attribute you should add one for accessibility and seo purposes.

    0
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    Hey it looks very good and if you want the color you can use the chrome extension color picker and take any colors from the web. Here the color: #FF527A

    Marked as helpful

    1
  • tyVespA 280

    @tyVespA

    Submitted

    I feel like the first two text sections in the mobile website are too small while the 2 images after (graphic design and photography sections) are too big, how can i make them more similar to the mobile design?

    Any other feedback is appreciated!

    Lucas Cerri 1,120

    @llKryptonixll

    Posted

    Hey great work , did you see the accessibility report? Your anchors are: <a href="#"> but you should add a discernible text. So if you are using icons as an anchor obviously there is no discernible text but for this we have aria-label attributes and with them you can add an discernible text. For example if you have an facebook icon and you are using it in an anchor tag you can write it like: <a aria-label="our facebook page" href="#">

    1
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    no problem i did not see the code but it works now nice

    0
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    i see you have added js files maybe its just the wrong path

    0
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    first of all the design looks good but the toggle is not working by me

    Marked as helpful

    1
  • hemzi 30

    @hemzi

    Submitted

    I'm not sure how to do the following... get an even split between the info pane and the hero image fill the hero pane with the image and apply the purple overlay. (overlay fixed)

    I'm not going to attempt mobile until i fix the desktop version. (sw5apped to mobile first already)

    Lucas Cerri 1,120

    @llKryptonixll

    Posted

    Hey first of all great work. And I hope I can help you with your problem.

    to get an even split i changed your css like this:

    i added a min-height of 500px to the body and the card it is just for responsivenes not for the even split

    `body { background-color: var(--primary-background); height: 100vh; min-height: 500px; font-size: 15px; font-family: "Inter"; display: flex; justify-content: center; align-items: center; }

    .card { max-width: 1440px; width: 90%; height: 500px; max-height: 80%; display: grid; grid-template-columns: 50% 50%; /// I used grid on the card and created two columns 1 for the text and one for the image

    grid-template-rows: 100%; justify-content: center; align-items: center; background-color: var(--primary-card-background); border-radius: 8px; }

    .info { display: grid; // also used grid to align the text i think you have more control than using margins or paddings

    width: 90%; height: 90%; //////////// to give the text a distance to the card container, i set the width and height to 90% instead of 100% and centered the info container justify-self: center; // }

    then i also worked on the image to make it more responsive and added the purple layer

    figure { width: 100%; height: 100%; position: relative; this is important for the purple layer } figure img{ width: 100%; height: 100%; border-top-right-radius: 8px; border-bottom-right-radius: 8px; }

    // this is your purple layer i used the css after pseudo class and positioned the layer absolute to the figure element

    figure::after{ content: ''; position: absolute; left: 0; background-color: #4f2a67a6; width: 100%; height: 100%; border-top-right-radius: 8px; border-bottom-right-radius: 8px; }

    Marked as helpful

    1
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    Hey first off all great work but it is not full responsive you should add a min height or make the card bigger at some point because the text ist not staying in his container.

    1
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    Great work I also made this with Tailwind and it was my first project with Tailwind. You can add media queries in Tailwind aswell https://tailwindcss.com/docs/responsive-design. I hope this helps if not you can check my solution https://www.frontendmentor.io/solutions/stats-preview-card-html-tailwind-css-gTtRv83I0x.

    0
  • Lucas Cerri 1,120

    @llKryptonixll

    Posted

    First of all great work but did you had any problems building it because the calculation is wrong or i am just stupid lol? If you need help you can check my solution or just ask me https://www.frontendmentor.io/solutions/tip-calculator-html-tailwind-css-vanilla-js-c5n3XM5vih

    0