Advice Generator App

Community feedback

• 

  Lucas Cerri•1,140

  @llKryptonixllPosted 8 months ago

  Hey nice work, but I would also call the function after the page has loaded, so that a random advice can be seen after the page has loaded and not an empty area. window.addEventListener("load", getAdvice); Or just call the function without the load event.

  The HTML looks very good but i would replace:
  
  <div class="dice">
      <img src="./images/icon-dice.svg" alt="">
  </div>
  
  with:
  
  <button aria-label="Get random advice button">
      <img src="images/icon-dice.svg" alt="Dice Icon">
  </button>
  
  This is better for screenreaders and accessibility
  

  Marked as helpful

  0

  ---

  

  Fitri Amelia•160

  @fitriamelia150Posted 8 months ago

  @llKryptonixll hi, thank you for the advice it is helpful for me..

  0