Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator App

@fitriamelia150

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas Cerri 1,120

@llKryptonixll

Posted

Hey nice work, but I would also call the function after the page has loaded, so that a random advice can be seen after the page has loaded and not an empty area. window.addEventListener("load", getAdvice); Or just call the function without the load event.

The HTML looks very good but i would replace:

<div class="dice">
    <img src="./images/icon-dice.svg" alt="">
</div>

with:

<button aria-label="Get random advice button">
    <img src="images/icon-dice.svg" alt="Dice Icon">
</button>

This is better for screenreaders and accessibility

Marked as helpful

0

@fitriamelia150

Posted

@llKryptonixll hi, thank you for the advice it is helpful for me..

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord