Latest solutions
Latest comments
- @AbdoB3Submitted over 1 year ago@lisztomania23Posted over 1 year ago
Could you please provide a walkthrough on how to run this locally?
0 - @devdavix2Submitted over 1 year ago@lisztomania23Posted over 1 year ago
Hello Obi, I looked at your code and saw that you centered the card by using
margin
. It is not good practice. Instead, you could have achieved it by giving thebody
aheight
of100vh
or100svh
anddisplay: flex;
flex-direction: column;
justify-content: center;
align-items: center;
and also for correctly positioning the background, instead of using:
background-position: left top, right bottom; background-size: 700px, 1000px; background-position-x: -10px, 600px; background-position-y: -350px, 300px;
you could have put
background-position: right 50vw bottom 45vh, left 50vw top 40vh;
Congrats on completing the challenge! Happy coding!
Ping me if you want me to make a few changes and create a PR.
0 - @franklynxchillSubmitted over 1 year ago@lisztomania23Posted over 1 year ago
I see you have posted quite a few solutions in the past few days. That's impressive! Though, why the hurry? This page is not very responsive. I'll check and suggest some changes when I get some time.
0 - @beowulf1958Submitted over 1 year ago@lisztomania23Posted over 1 year ago
Hello, I made a few tweaks and created a pull request to your GitHub repo; merge it if you like.
1 - @beowulf1958Submitted over 1 year agoWhat are you most proud of, and what would you do differently next time?
learning to use Sass variables
What challenges did you encounter, and how did you overcome them?I had a bit of trouble with centering the card at first; check on solutions to other challenges by other people and was able to finally get it centered
What specific areas of your project would you like help with?my h1 breaks the line differently than the design jpg
@lisztomania23Posted over 1 year agoHello, I made a few tweaks and created a pull request to your GitHub repo; merge it if you like.
1 - @Mahmoud-770Submitted over 1 year ago@lisztomania23Posted over 1 year ago
Hello, I have submitted a pull request to your GitHub repository with some adjustments to your code, ensuring responsiveness. Additionally, I have included support for mobile devices. See the changes I made and merge it if you like.
Marked as helpful1