Design comparison
Solution retrospective
learning to use Sass variables
What challenges did you encounter, and how did you overcome them?I had a bit of trouble with centering the card at first; check on solutions to other challenges by other people and was able to finally get it centered
What specific areas of your project would you like help with?my h1 breaks the line differently than the design jpg
Community feedback
- @NehalSahu8055Posted 12 months ago
Hello Coder 👋
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
Use
min-height:100vh
instead ofheight:100vh
Todynamically center the card
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
.
I hope you find this helpful.
Happy coding😄
Marked as helpful1 -
- @lisztomania23Posted 12 months ago
Hello, I made a few tweaks and created a pull request to your GitHub repo; merge it if you like.
1@lisztomania23Posted 12 months agoHello, I used the Pixel Perfect extension to try to match it with the given design, but I think my screen dimensions were set differently. As a result, it was showing as pixel perfect for that configuration. Now, upon reviewing the screenshot, I see that it is not. I simulated the given dimension of 1440px, made some tweaks, and submitted a revised pull request.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord