Profile Card Component - My Solution

Community feedback

• 

  lisztomania23•170

  @lisztomania23Posted about 1 year ago

  Hello Obi, I looked at your code and saw that you centered the card by using margin. It is not good practice. Instead, you could have achieved it by giving the body a height of 100vh or 100svh and display: flex; flex-direction: column; justify-content: center; align-items: center;

  and also for correctly positioning the background, instead of using:

  background-position: left top, right bottom;
  background-size: 700px, 1000px;
  background-position-x: -10px, 600px;
  background-position-y: -350px, 300px;
  

  you could have put background-position: right 50vw bottom 45vh, left 50vw top 40vh;

  Congrats on completing the challenge! Happy coding!

  Ping me if you want me to make a few changes and create a PR.

  0