Skip to content
OverviewSolutions
4
Comments
7
Liam
@liamchivers23

All comments

  • Mark Halstead•10
    @Mark-HalsteadSubmitted over 2 years ago

    Practised some basic HTML, CSS, boostrap and javascript!

    I am a beginner and I cannot get the Javascript file to work:

    1. I am trying to select the anchor tag with a particular class and change its href so I am redirected to the HTML file which returns the correct rating. I have tried using the Javascript DOM using statements such as querySelector and getElementbyID but with no luck. Could someone help me please?

    2. Does the visual layout using html css and bootstrap look ok?

    3. I cannot find how to make this suitable for mobile viewing. How do I do this?

    Interactive-Rating-Component

    1
    Liam•150
    @liamchivers23Posted over 2 years ago

    Hi Mark.

    To answer some of your questions:

    1 - more info needed, are you trying to change the image when the submit button is clicked? you could create a seperate card then put a display of none on the current card when its clicked. Hope this solved your issue.

    1. Yes, it looks fine :)

    2. Media queries will help with mobile viewing :)

    Hope this helps!

    Marked as helpful
    0
  • Keagan Dickinson•160
    @PhisherFTWSubmitted over 2 years ago

    I found having the hover effect while being able to click the button to change the background color quite difficult and still don't have it working right, I tried doing it with the onmouseover and onmouseleave. Still, then I couldn't get the button to stay clicked when I went to click the submit button, I know my code is very rough, I have only recently learnt DOM javascript and this was my first time putting it into a project, any. All feedback is absolutely welcomed, and offering alternate and better solutions, please feel free.

    Thanks!

    interactive-rating-component

    2
    Liam•150
    @liamchivers23Posted over 2 years ago

    Hi, mate. You can use the :hover pseudo-class to make the hover happen on the rating buttons, then use an eventlistener to change it from grey to orange when the button is clicked.

    Also some more padding on the bottom of the rating buttons as the submit button is too close. And maybe some more padding inside the button as its quite thin.

    Hope some of these suggestions help!

    Marked as helpful
    2
  • Alex•240
    @AlexManu05Submitted over 2 years ago

    Any feedback on mistakes i've made is appreciated. Keep calm and keep coding 🤘 !!

    Responsive rating card

    2
    Liam•150
    @liamchivers23Posted over 2 years ago

    Oh and im sure instead of adding and removing the class in JavaScript you could use toggle, saves you a line or two of code i believe :)

    Marked as helpful
    1
  • Alex•240
    @AlexManu05Submitted over 2 years ago

    Any feedback on mistakes i've made is appreciated. Keep calm and keep coding 🤘 !!

    Responsive rating card

    2
    Liam•150
    @liamchivers23Posted over 2 years ago

    Hi mate, i thought that when you click the submit button then the thank-you layer is supposed to happen, but it happens when you click a rating number instead.

    Other than that it looks great! Good job!

    Marked as helpful
    1
  • Liam•150
    @liamchivers23Posted over 2 years ago

    It seems that the page doesnt load.

    0
  • Liam•150
    @liamchivers23Posted over 2 years ago

    Hi, Alazar. Your Solution, While good lacks responsiveness. Through from 1000px to 375px it looks slightly squashed. Maybe try and change the flex-direction of your project to column so that it displays as it would in the mobile view.

    Although this is just my opinion and you dont have to take my advice,

    Liam. :)

    Marked as helpful
    0
  • Nairet•10
    @NaiforsythSubmitted over 2 years ago

    Hi!

    I liked the challenge, so I'd like to ask:

    -Is it a good idea to use the CSS grid for this case? Or maybe it's better to use it for something more complex?

    -Is it better to use rem or px or '%' for Responsive?

    Thanks

    QR code component challenge using HTML and Sass

    4
    Liam•150
    @liamchivers23Posted over 2 years ago

    Either 'rem' or percentage is fine for responsive design.

    Good job on the challenge :)

    Marked as helpful
    0