Design comparison
Solution retrospective
I found having the hover effect while being able to click the button to change the background color quite difficult and still don't have it working right, I tried doing it with the onmouseover and onmouseleave. Still, then I couldn't get the button to stay clicked when I went to click the submit button, I know my code is very rough, I have only recently learnt DOM javascript and this was my first time putting it into a project, any. All feedback is absolutely welcomed, and offering alternate and better solutions, please feel free.
Thanks!
Community feedback
- @liamchivers23Posted over 2 years ago
Hi, mate. You can use the :hover pseudo-class to make the hover happen on the rating buttons, then use an eventlistener to change it from grey to orange when the button is clicked.
Also some more padding on the bottom of the rating buttons as the submit button is too close. And maybe some more padding inside the button as its quite thin.
Hope some of these suggestions help!
Marked as helpful2 - @CyrusKabirPosted over 2 years ago
Hello 😃☺, you did good on this challenge and it's a very good way to learn new things you know learning new things or concepts in a language or a tool and implement them in real code or simple challenges like that. for your problem about changing background color in two states (mouse over and mouse click) as @Liam said you can use pseudo selectors in css like :hover, :focus, etc. and try to use some folder structure in your code base. I know this is a little project and you have only one .js file or .css file but adding those files to separate folders like any js code to js folder or script folder and any style or css file to css folder. this can help a little about code maintainability and other stuff. hope this could help you
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord