@theadgSubmitted almost 2 years ago
What should I improve on my code? I appreciate all kinds of feedbacks :)
Khubaibul Islam Shakib
@khubaibulAll comments
- @khubaibulPosted almost 2 years ago
I have just checked your project. You have done it very well.
Although you can improve some logic.
First, the Side navbar not changing to summary when going to the summary section. Add-ons remain. Try to solve it.
Secondly, in the summary section the total calculated amount is coming NaN (Not a Number).
Finally, try to add a favicon.
Best of luck.
0 - @Don-AlvinSubmitted almost 2 years ago@khubaibulPosted almost 2 years ago
Hi! I have checked your project. You have done it very well. Although you can update some designs.
First, please try to align the main content to the centre from the left. Or you can take more space for images and text+button content. Try to give an outline or border in the navigation link based on active status.
There is one more issue that I have faced is, the number remains only one at the top of the shopping cart icon.
Have a good day.
Marked as helpful1 - @ayra-saSubmitted almost 2 years ago
Hello
This is my solution for todo app challenge, i know my javascript code is still a mess. if anything is missing please let me know 😊
@khubaibulPosted almost 2 years agoI have checked your project. You have done it very well. Keep it up.
Marked as helpful0 - @meshkat-hossainSubmitted almost 2 years ago@khubaibulPosted almost 2 years ago
Hi! I have checked your project. You have done it well. Try to improve some components like buttons, input field and selectable plan.
First of all, try to align all buttons to be fixed at the bottom. Now your some button is under the div. Like Next Step, Back, Next etc. Secondly, use the input type "email" for an email input field.
Then give some CSS effects based on the selected card. So that user can understand which card he selected.
Also, your yearly plan isn't working somehow.
Best of luck. Have a good day.
0 - @Samuel-AmaroSubmitted almost 2 years ago
This project is very interesting for those who want to delve into topics such as forms, especially validations, in this project I did not use any library, only the native resources on the client side, for validating forms. If you can, give me feedback on the submitted implementation.
@khubaibulPosted almost 2 years agoHi! I have checked your project. Very well done.
I faced a problem while filling in the phone number field. Because the regular expression is a bit tricky. Try to use normal regEx for the phone number. It would be good for users I think.
0 - @Vladimir0657305Submitted almost 2 years ago@khubaibulPosted almost 2 years ago
Hi. I have checked your project.
The project went very well. You can still update some things if you want
First, use the input type email for the Email Address and input type tel for the phone number. Then use some CSS for the selected plan so the user can understand which card he selects. You can use some CSS based on the checked attribute.
You can also update in responsiveness. Input tags aren't fully responsive.
Marked as helpful1 - @unteacatalinSubmitted almost 2 years ago
Hi, I'm not sure if html input patterns work inside JSX (i.e. the phone number pattern doesn't seem to work all the time). Also I don't know how to use drop-shadow in CSS (e.g. if I set a drop-shadow on a form it will drops shadows on all html controls but not on the form itself). I had to use box-shadow to make the forms as close as possible to the templates (i.e. box-shadow has a small border all around and I don't know how to get rid of the borders). Thank you!
@khubaibulPosted almost 2 years agoTry to change the input field text and input box background. Now the text is almost invisible. You can use focus for that.
0
