@ROHIT-130SESubmitted 11 months ago
It's nice to practice and learn more, I hope to work on more challenges at the earliest possible and please feel free to review and share your feedback on this work.
Karthik SP
@karthispAll comments
- @karthispPosted 11 months ago
Great work Rohit.
Just a few suggestions
- Give <html>, <body>, #container a height of 100% and align #container to the 'center' using align-items CSS property for flex.
Marked as helpful0 - @kylecloeteSubmitted 12 months ago
This has been one of my favourite challenges to complete so far, making use of JavaScript and actually see you code do something was so interesting for me
When researching solutions for this challenge as well as looking at a couple of YouTube videos. I was left confused no offense to those people but what they were doing just seemed so convoluted for a beginner project.
I recommend looking at freeCodeCamps video "JavaScript Programming - Full Course"
Any Advice would be greatly appreciated especially regarding the structure of my html and appropriate tags to use for which section and how to clean up some of my JavaScript
@karthispPosted 12 months agoGreat Job.
Looks very close to the original design.
Just a few suggestions
- increase the 'letter-spacing' for button text
- Increase line height for <p>
- 1 rem margin for '.rating_component' and <h1> should be good enough
0 - @MelvinAguilarSubmitted over 1 year ago
Hi there 👋, I’m Melvin and this is my solution for this challenge. 🚀
🛠️ Built With:
- TailwindCSS
- npm - prettier
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. 😊✌️
@karthispPosted over 1 year agoHi @MelvinAguilar you've done a great job with implementing the given design. Keep up the good work. I've got a lot of things to learn from you.
Just a small suggestion:
I see that you've used clip for sr-only (H1), instead try using clip-path. Apparently, that's what is recommended. https://developer.mozilla.org/en-US/docs/Web/CSS/clip-path
1
