Design comparison
Solution retrospective
It's nice to practice and learn more, I hope to work on more challenges at the earliest possible and please feel free to review and share your feedback on this work.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there 👋. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
- Wrap the page's whole main content in the
<main>tag.
- For specificity reasons you should work with classes instead of ids because they are more reusable. You can use ids to work with JavaScript, but you should use classes to style your elements. You can read more about this here 📘.
-
You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.
CSS resets that are widely used:
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1 - Wrap the page's whole main content in the
- @karthispPosted 11 months ago
Great work Rohit.
Just a few suggestions
- Give <html>, <body>, #container a height of 100% and align #container to the 'center' using align-items CSS property for flex.
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord