Skip to content
OverviewSolutions
6
Comments
2
SukiyakiFiend
@josuke0227

All comments

  • Maria•290
    @itsfedorukSubmitted over 3 years ago

    Hi there 👋 For this challenge, I focused fully on using flexbox on both mobile and desktop – instead of a combo of flexbox (mobile) and grid (desktop) like I usually do. It helped to think more on how to re-use the structure which was set first for mobile, and get familiar with more features of flexbox.

    Any feedback – let me know, super happy to hear any pointers on how to improve my code 🙌

    Preview card using HTML/CSS, mobile & desktop on flexbox

    2
    SukiyakiFiend•115
    @josuke0227Posted over 3 years ago

    Hello, Maria.

    I like your clean BEM notation for the class names👍!

    I'd like to suggest you one thing. You can use "rem" or "em" unit for font-size instead of "px". This is because the display of these day has high density, it can display 1000px even if its width is 500px. "px" unit may cause your text size shrink when it is displayed.

    Also "rem" and "em" unit works well when someone👵👴 changed the text size from your browser's setting!

    Happy coding! 😁

    1
  • Aastha Anand•345
    @aasthaanand123Submitted over 3 years ago

    I would appreciate if you all suggest me ways to improve my code since I really faced difficulties in applying the background color and at last took a shortcut(not using css) and also I faced certain problems in media queries and I'm not really sure if its written in a correct manner.

    Html5, Css3(flexbox and media queries)

    2
    SukiyakiFiend•115
    @josuke0227Posted over 3 years ago

    Hello, Aastha!

    Good work, mate👍

    What I'd like to suggest is as below:

    1. You can apply font-style globally if you set it to body in your stylesheet.
    2. The break point which the layout is switched to desktop one may be a bit too small since the left side of the contents is outside of the screen.

    I hope it helps.

    Happy coding! :)

    0