Html5, Css3(flexbox and media queries)

Community feedback

• 

  Tereza•605

  @sirriahPosted over 3 years ago

  Hello,

  Nice work. I have some suggestions:

  • Not everything should be in div tag. For example for paragraphs use p tag, etc. Look at some articles or videos - list of all tags and FreeCodeCamp - semantic HTML
  • Try to use BEM naming or another naming standard. This project is small, but If you will work on something bigger, you will get lost. [Video about BEM] (https://www.youtube.com/watch?v=SLjHSVwXYq4)
  • As josuke0227 mentions above - the responsiveness is not good. Try to add another breakpoint. I know that in the starter files are only designs for mobile and desktop, but It would be better, if the page will be visible in all devices. [Responsive design] (https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Responsive_Design) Your browser will help you with the media queries [Responsive design mode in Firefox] (https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode)

  Have a nice day :)

  1

  ---

  

  Aastha Anand•345

  @aasthaanand123Posted over 3 years ago

  @sirriah Thanks for the feedback. I do think I'll start incorporating BEM in my code and I'll look into the responsiveness also since I did struggled in media queries the code became really messy.

  0
• 

  SukiyakiFiend•115

  @josuke0227Posted over 3 years ago

  Hello, Aastha!

  Good work, mate👍

  What I'd like to suggest is as below:

  1. You can apply font-style globally if you set it to body in your stylesheet.
  2. The break point which the layout is switched to desktop one may be a bit too small since the left side of the contents is outside of the screen.

  I hope it helps.

  Happy coding! :)

  0

  ---

  

  Aastha Anand•345

  @aasthaanand123Posted over 3 years ago

  @josuke0227 Thank you for the feedback! I'll surely look into the code again.

  1