Skip to content
OverviewSolutions
3
Comments
3
Jakša Maršić
@jmarsic

All comments

  • Alexander Pavlovic•80
    @Pavlovic2001Submitted about 1 year ago
    What are you most proud of, and what would you do differently next time?

    Nothing specifically.

    What challenges did you encounter, and how did you overcome them?

    Nothing for now.

    What specific areas of your project would you like help with?

    Nothing yet.

    Html, CSS

    1
    Jakša Maršić•70
    @jmarsicPosted about 1 year ago

    Hello there. I would like to give you few tips that helped me:

    • inside HTML it would be best to have one main element because it specifies the main content of a document instead of article element that is more for forum (like) sites
    • it would be best to avoid using id because of specificity and other things that we need to keep in mind. Simple solution is to use class just once
    • no point of using h4, just use h2 and style it
    • try to use class for every element you want to style (not descendant selector)

    I hope this guidelines will help you in the future.

    Kind regards, Jake.

    0
  • joeyturbo•50
    @joeyturboSubmitted about 1 year ago
    What are you most proud of, and what would you do differently next time?

    was able to knock this one out pretty quick without much googling

    What challenges did you encounter, and how did you overcome them?

    nothing in particular

    What specific areas of your project would you like help with?

    none

    Blog Card Preview

    2
    Jakša Maršić•70
    @jmarsicPosted about 1 year ago

    Hello and well done. You did almost the same design as given. Here are a few things to keep in mind:

    • div class="card-container" should be main because it specifies the main content of a document
    • <div class="tag">Learning</div> should be span
    • there is no need to use h4 because you can use h2 and style it with CSS
    • in CSS better approach is to set margin-bottom on every element and not to use default flex-direction: column; distance
    • comments are no no to have on production

    I hope this tips will help you. Have a nice day, Jake

    Marked as helpful
    2
  • Jakša Maršić•70
    @jmarsicPosted about 1 year ago

    Hello, you did very well, although according to your HTML and CSS there are few things that should be changed:

    • Inside HTML you used internal styling for fonts and also external styling for all other styles. Better approach would be to use link tags (in html head) for fonts or inside external stylesheet.css with @import rule at the top of the file
    • Inside HTML body element first div class="container" should be main element because that container is main thing on the page
    • There is no point of using id on the img element. Otherwise you should avoid id's because of simplifying things and id's specificity that we need to keep in mind if we use them
    • This is small challenge but in the future the best approach would be to add classes to all elements that you will need to style
    • Inside CSS try to match styles form the top to the bottom of the HTML classes (not in alphabetical order)
    • Always double check readability of code (CSS - 11 line) and use auto-format (left shift + alt + F)
    • font-family (and font size) is best to set on body element
    • According to preview height of component and font-size should bi smaller
    • According to preview margines, paddings and border-radius should be little bigger

    I hope this guidelines will help you in the future. Kind regards, Jake

    Marked as helpful
    1