Jakša Maršić• 70
@jmarsic
Posted
Hello and well done. You did almost the same design as given. Here are a few things to keep in mind:
div class="card-container"should bemainbecause it specifies the main content of a document<div class="tag">Learning</div>should bespan- there is no need to use
h4because you can useh2and style it with CSS - in CSS better approach is to set
margin-bottomon every element and not to use defaultflex-direction: column;distance - comments are no no to have on production
I hope this tips will help you. Have a nice day, Jake
Marked as helpful
2
joeyturbo• 50
@joeyturbo
Posted
@jmarsic this is great advice and definitely blindspots i have right now. i think vscode and just using '.classname' to generate a div kind of hurt my tendency to use more semantic tags. and yeah i also default to flex way too much. i really appreciate you taking the time to help me out. thank you.
0
Jakša Maršić• 70
@jmarsic
Posted
@joeyturbo I'm glad I could help, kind regards.
0
