Blog Card Preview

Community feedback

• 

  Jakša Maršić•70

  @jmarsicPosted 7 months ago

  Hello and well done. You did almost the same design as given. Here are a few things to keep in mind:

  • div class="card-container" should be main because it specifies the main content of a document
  • <div class="tag">Learning</div> should be span
  • there is no need to use h4 because you can use h2 and style it with CSS
  • in CSS better approach is to set margin-bottom on every element and not to use default flex-direction: column; distance
  • comments are no no to have on production

  I hope this tips will help you. Have a nice day, Jake

  Marked as helpful

  2

  ---

  

  joeyturbo•50

  @joeyturboPosted 7 months ago

  @jmarsic this is great advice and definitely blindspots i have right now. i think vscode and just using '.classname' to generate a div kind of hurt my tendency to use more semantic tags. and yeah i also default to flex way too much. i really appreciate you taking the time to help me out. thank you.

  0

  

  Jakša Maršić•70

  @jmarsicPosted 7 months ago

  @joeyturbo I'm glad I could help, kind regards.

  0
• 

  Maobugichi•470

  @MaobugichiPosted 7 months ago

  great work

  1