QR Code Webpage - HTML & CSS

Community feedback

• 

  Jakša Maršić•70

  @jmarsicPosted 8 months ago

  Hello, you did very well, although according to your HTML and CSS there are few things that should be changed:

  • Inside HTML you used internal styling for fonts and also external styling for all other styles. Better approach would be to use link tags (in html head) for fonts or inside external stylesheet.css with @import rule at the top of the file
  • Inside HTML body element first div class="container" should be main element because that container is main thing on the page
  • There is no point of using id on the img element. Otherwise you should avoid id's because of simplifying things and id's specificity that we need to keep in mind if we use them
  • This is small challenge but in the future the best approach would be to add classes to all elements that you will need to style
  • Inside CSS try to match styles form the top to the bottom of the HTML classes (not in alphabetical order)
  • Always double check readability of code (CSS - 11 line) and use auto-format (left shift + alt + F)
  • font-family (and font size) is best to set on body element
  • According to preview height of component and font-size should bi smaller
  • According to preview margines, paddings and border-radius should be little bigger

  I hope this guidelines will help you in the future. Kind regards, Jake

  Marked as helpful

  1

  ---

  

  //aki•20

  @akimarqPosted 8 months ago

  @jmarsic Thanks the help, Jake, I'll keep all of these in mind for my future projects. Thank you very much!

  0

  

  Jakša Maršić•70

  @jmarsicPosted 8 months ago

  @AchillesMarq I'm glad I could help. Good luck

  0