Design to code
What challenges did you encounter, and how did you overcome them?layout
What specific areas of your project would you like help with?nothing
Design to code
What challenges did you encounter, and how did you overcome them?layout
What specific areas of your project would you like help with?nothing
Hi there!
Your solution looks great but there's some room for improvement. The cards aren't centered yet, you could try using the CSS Grid layout.
For accessibility, you could use some more semantic HTML-elements. So instead of using <div>'s for the cards, perhaps use <article> or <section> tags. There are a few more, so try and see if you can find some other <div> elements that could be replaced by more semantic ones.
Hi there,
Your solution looks great! Upon checking your code I noticed you use a lot of divs, while there could be more semantic html elements used. So I think you could improve on that. That will also improve the accessibility.
Also, I think you need to define the mobile breakpoint earlier, when testing I notice that it takes quite some width before the breakpoints hits, making a big piece of the component overflow the screen before switching to the mobile version.
Your code is well-readable and the overall product looks very close to the design. So it's up to you if you want to fine-tune the rest, either way: great job!
The challenge was pretty simple, however I am proud of the very last section as I forced myself to work using the table
tag in HTML which made finishing quite a lot harder than if I were to use div
s.
The most challenging thing I had to figure out was the table
of HTML. I don't think I've ever used it in a real-life scenario, but I forced myself to do it to make the HTML gods proud. I had to do a lot of googling of the table
tag and how to style it properly.
Looks great! I just notice there's a big "white" space on the bottom of your solution. I am not sure but it might have something to do with the '100svh' CSS property on the body. Try removing that property, that might also solve the fact that your solution looks a bit smaller than the design. Good luck and have fun coding!
Your solution looks great already, but there are some improvements that could be made. Not all links that are in the design can be found back in your solution. Also, you've not yet made use of semantic HTML tags, so that's something you could dive into to learn and implement.
Lastly, there are some spelling issues. So there's that to improve. Good luck and have fun coding!
Solution looks great! Perhaps try and clean up the repository, deleting some obsolete files and edit the Readme file. It now still has the default content.
I had no knowledge of creating web pages, so past public repositories were a great help.
Looks great! You've used semantic HTML tags. There are some differeces between the design and your solution, but they are quite minor. My own doesn't totally follow the design either. Good job!