@satyatoratiSubmitted 5 days ago
P
jedcanchola
@jedcancholaAll comments
- @mnrohodenSubmitted 16 days ago
- @ivngzmnSubmitted 21 days agoWhat are you most proud of, and what would you do differently next time?
I learned more about group hovering to ensure a seamless hover transition on the list item with a link.
@jedcancholaPosted 21 days agoIt includes semantic HTML at a certain level but there are multiple divs in the HTML. It includes the proper alt texts. The layout only includes 2 screens, mobile and desktop, font sizes are sligtly different, and the font was not loaded in the live url.
The code is well structured but I think the ul element could be avoided by implementing a flex column.
The CSS code is hard to read as there are multiple nested elements.
Marked as helpful0 - @fincodewizSubmitted 21 days ago@jedcancholaPosted 21 days ago
Semantic HTML was used but could have been better by implementing an article as a card, and define a main and footer within the card.
The Image is accessible and used the correct alt description.
The different screen sizes were not implemented, the image and fonts are static, from the design fonts and size should be different depending on the screen size.
The code is well structured but I think a different approach should be used with the SVG as it takes a lot of the space on the html.
It only differ from the design in the size.
Marked as helpful0 - @ChrisRolandSubmitted 25 days ago@jedcancholaPosted 25 days ago
Good usage of main section. Need usage of semantic html tags as article, for the card. There is no alt text for the qr image. The code looks good in different screen sizes, The solution differs slightly from the original but it is a good solution.
1
