Skip to content
OverviewSolutions
14
Comments
13

James Brown

@jamesbrown173260 points

Hi! I'm James, I'm a self-taught programmer! I like coding, running and flapjacks! 🍰

Latest solutions

View more solutions

Latest comments

  • James Brown•260
    @jamesbrown173Posted 8 months ago

    Looks great! No issues and functions well, also the fade in out looks good

    Marked as helpful
    1
  • James Brown•260
    @jamesbrown173Posted 8 months ago

    It's really good, everything updates well. It's clear and responsive.

    0
  • khalagai•370
    @khalagaiSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?
    • Getting the logic to work.
    • Learning about the aria attribute for screen readers.
    What challenges did you encounter, and how did you overcome them?
    • Refactoring the code to reduce repetition. Reading more on refactoring helped, however, I believe more refactoring is possible.
    What specific areas of your project would you like help with?

    Any feedback on how I can further make the code simpler and more readable.

    Tip Calculator App

    1
    James Brown•260
    @jamesbrown173Posted 8 months ago

    Design:

    • The design is clean and easy to follow, I see you've made adjustments for your own styling that's great. All items align well and use correct icons.
    • When hover over the custom tip input the added border makes the div jump up and down. You could fix this by adding a 'fake' border that is the same color as the background in line 31 of index.hmtl.
    • Site is responsive to all screen sizes.
    • On the mobile size the background blue color is only applied to the div container not the body, so it leaves white padding on the L and R. I think you could either apply the BG color to the body or remove X padding to fix this line 13 index.html.

    Javascript code:

    • Clean, easy to follow.
    • Could be improve with some comments for each section.
    • Functions well to calculate the amounts.
    • As far as I can tell the bill only calculates when the tip inputs change, you could at an event listener for 'keyup' to the people and bill elements if you want it to be more responsive and change whenever a user types. You'd also need to add conditional statements to prevent submission if one or more fields were empty.

    🤗 Great job and happy coding! 🤗

    1
  • P
    Robert Crocker•410
    @robcrockSubmitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    This challenge gave me a chance to use environment variable in NextJS, which I hadn't used before. It also gave me a chance to create a nice grid layout.

    What challenges did you encounter, and how did you overcome them?

    I hadn't used environment variable in NextJS before. So I was getting some errors while deploying to Vercel that I hadn't seen before, but now I know exactly how to handle those issues in the future.

    What specific areas of your project would you like help with?

    I am alway open to feedback on how I'm using Tailwind and NextJS. This specific project gave us a chance to create our own endpoint, so feedback on that is welcome as well.

    Time Tracking Dashboard Solution

    #react#tailwind-css#next
    1
    James Brown•260
    @jamesbrown173Posted 8 months ago

    The grid overflows a little on the desktop view.

    0
  • P
    Stephen Ostler•210
    @steveostlerSubmitted 9 months ago
    What specific areas of your project would you like help with?

    I did a little research to complete this challenge but it's mainly my work (about 85%). I had to get the code for an email validation script from stack overflow. This is the only thing I do not understand in the code. Do I need to understand regex?
    Is it ok to rely on javascript validation?

    Newsletter sign-up form with success message solution

    1
    James Brown•260
    @jamesbrown173Posted 8 months ago

    Great, clean code easy to read with comments. Functions well with client side validation.

    I'm not sure I used regex in mine but I don't understand it fully, I think it's a powerful tool for parsing data.

    0
  • Biruk Moges•280
    @lost50U1Submitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    It took me sometime even if i have some basic knowledge on javascript and it was challenging and i want to improve more on javascript and make the javascript code i added using less code even though it is challenging i finished the challenge.

    What challenges did you encounter, and how did you overcome them?

    if it was only making it show one of the share tooltip it was easy but making it show based on different screen is challenging and i solved it by making 3 functions and buttons.

    What specific areas of your project would you like help with?

    if someone can review both the tailwind and javascript code i used on the active state and tell me if there is a simple method to do it better i will appreciate it

    Article Preview Component with Vanilla js and Tailwind

    #tailwind-css
    1
    James Brown•260
    @jamesbrown173Posted 9 months ago

    **First Impressions

    • It functions well at first glance, and the buttons work to show and hide the share element. However when transitioning between sm and md breakpoints the share element doesn't change. I think we need to add hidden class types for the different breakpoints in the JS code.

    • The site is responsive and functions well.

    0
View more comments