@kurniantoegaSubmitted over 1 year ago
Emmanuel Akpan
@heisemmaco-devAll comments
- @heisemmaco-devPosted over 1 year ago
Hey Ega, you did i really good job there with design and also with javascript but there is one thing that you didn't get well
The issue lies in the if statement checking if the email input is empty. Currently, it uses email.value === "" to verify emptiness. However, this condition doesn't account for spaces, so if spaces are entered, it still registers as content in the input.
To solve this, consider using email.value.trim() for the condition. This adjustment checks if there's no content after trimming spaces. So, the updated code would look like this: if (email.value.trim() === "") { email.style.outlineColor = "red"; errorMsg.textContent = "Email cannot be empty"; } Now, it'll properly identify an empty input, including cases where there might be only spaces. This way, the form validation becomes more accurate.
I hope your fine this helpful
Marked as helpful0 - @pguevara135Submitted over 1 year ago@heisemmaco-devPosted over 1 year ago
Hi bro, you did a very good job in your coding challenge, i admire the way you structure and style the web page, but you missed only one thing which is the background color, i can see that you mistakenly use container background color as the main background, that wrong, you can fine the color description in file named style guild, if you fine this comment helpful you can mark it a helpful and follow me, thank
0 - @GeneroustechnocratSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
wow!! bro you try oo, e no easy abeg, continue your good work and looking forward to see you next project bro
0 - @Yeiifrensk8Submitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi Yeiifrensk, Great work right their, I love the responsiveness of the card but on Mobil and desktop but their is one thing you you missed the background color, the background color is not supposed to be with, you can fine the background color on the style guide.
I hope you fine this helpful
Marked as helpful1 - @dellenarSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I must say you did a wonder job their, main look that the solution it look as if you use css flame works but you did it with pure css nice work their, i really love layout.
continue the good works bro, no cap, you did a really things their,
i hope you find this comment more encouraging and helpful
Marked as helpful1 - @ren-daniSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I have other recommendations regarding your code that I believe will be of great interest to you. CSS: I WILL LIKE TO GO STRAIGHT TO THE POINT your images look more of white you can correct this by making the background color of the image div purple and then apply this property to the div: "background-blend-mode: multiple;"
secondly, your image shrink with the whole card, i took a look that your code an saw that your use the source tag to set you image media quire, that good acually but you have to use only one instead of setting two source code at your picture tag
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Marked as helpful1 - @NacsimentoSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I have other recommendations regarding your code that I believe will be of great interest to you. CSS: I WILL LIKE TO GO STRAIGHT TO THE POINT your images look more of white you can correct this by making the background color of the image div purple and then apply this property to the div:
"background-blend-mode: multiple;"
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Marked as helpful0 - @Vorpalv2Submitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hey, Hey, I think the reason why your image is not showing up is because it's not being linked correctly. You have the file path as : /images/image-qr-code It should be: ./images/image-qr-code. The problem is that you didn't add . That is full stop to the from Try it out :)
0 - @sorin7345Submitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi sorin7345, Congratulations 👏👏 on completing your project, I like the position your layout. Ok about the purple 💜 color that fade on the pic, you can actually do that by add background color to the tag that wrapped the picture then you add this css property "background-blend-mode: multiple" to that same tag.
I hope you fine this helpful
0 - @GeneroustechnocratSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi Generoustechnocrat, Congratulations on completing your project, you did very well in the layout but the width you give to you container, is too small because you only set the property to width instead of max-width and you gave the image a width of some number I can't remember, I suggest you set the width of your image to 100% so it will complete cover your items container.
I hope you fine this useful
Marked as helpful0 - P@SamuelKRuan1901Submitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi James, Congratulations on completing your project, I see you image is not show because you didn't direct your url to the place where the image can, I should say you should try to abjust that. To ../images/ name of the image, if you are using vs studio the images will pop up when you do that and then you select the image. Secondly you used <b> tag to make your button, I guess that's is the wrong path, use the button tag to do that.
I hope you find This helpful
Marked as helpful0 - @Erick384Submitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi Erick384, Congratulations on completing your front mentor project, I love your how you layout but you add height "100%" in your image that why you image doesn't look nice, I will always prefer you don't use height on images and also you didn't use the right font family, you can see that right to use on the style-guild.md on the file provided for you.
I hope this will be helpful
0 - @j-0-n-e-zSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi j-0-n-e-z, Congratulations on completing this project, I noticed something, your container is not responsive in Mobil view, I suggest you you should you media quire on that.
I hope you fine this insight helpful
Marked as helpful1 - @Olagunju9148Submitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi Olagunju, Congratulations on completing your first frontend mentor challenge, you did everything well but you page is not responsive on a mobile device this is because you add min-width in your media quire and you didn't direct your flex to column in your real body
Marked as helpful0 - @narasimhanaik7013Submitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi Narasimhanaik, congratulation on completing you project, i love you layout but the left background stuff, you didn't use the right color, use linear-gradient( 40deg, hsl(264, 100%, 61%), hsl(293, 100%, 63%); that's right color to use and you can just copy this one. I hope you find this helpful
Marked as helpful0 - @VladMishchukSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hi @VladMishchuk, congratulation on completing you project, i love you layout but the left background stuff, you didn't use the right color, use linear-gradient( 40deg, hsl(264, 100%, 61%), hsl(293, 100%, 63%); that's right color to use and you can just copy this one. I hope you find this helpful
0 - @LordY1susSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hello 👋, Well done on completing the challenge! 🎉
you did very thing well expect applying opacity to you image to make that effect, use this instend of that, setting the picture tag to {background-blend-mode: multiply} it will have that effect or if you didn't understand, you can reply to this my comment so that pull the issue in your github respository, so you will merge it.
hope this was helpful
Marked as helpful1 - @rathmanjonathanSubmitted almost 2 years ago@heisemmaco-devPosted almost 2 years ago
Hello 👋, Well done on completing the challenge! 🎉
I can see that the image you uploaded did show because you did upload the image file to your github respository and you didn't center conter in the middle because you did add min-height: 100vh to your body tag.
I hope this was helpful
0
