Skip to content
OverviewSolutions
32
Comments
32
Emmanuel Akpan
@heisemmaco-dev

All comments

  • Emmanuel Akpan•790
    @heisemmaco-devPosted 11 months ago

    Hey Ega, you did i really good job there with design and also with javascript but there is one thing that you didn't get well

    The issue lies in the if statement checking if the email input is empty. Currently, it uses email.value === "" to verify emptiness. However, this condition doesn't account for spaces, so if spaces are entered, it still registers as content in the input.

    To solve this, consider using email.value.trim() for the condition. This adjustment checks if there's no content after trimming spaces. So, the updated code would look like this: if (email.value.trim() === "") { email.style.outlineColor = "red"; errorMsg.textContent = "Email cannot be empty"; } Now, it'll properly identify an empty input, including cases where there might be only spaces. This way, the form validation becomes more accurate.

    I hope your fine this helpful

    Marked as helpful
    0
  • Emmanuel Akpan•790
    @heisemmaco-devPosted 12 months ago

    Hi bro, you did a very good job in your coding challenge, i admire the way you structure and style the web page, but you missed only one thing which is the background color, i can see that you mistakenly use container background color as the main background, that wrong, you can fine the color description in file named style guild, if you fine this comment helpful you can mark it a helpful and follow me, thank

    0
  • Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    wow!! bro you try oo, e no easy abeg, continue your good work and looking forward to see you next project bro

    0
  • Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hi Yeiifrensk, Great work right their, I love the responsiveness of the card but on Mobil and desktop but their is one thing you you missed the background color, the background color is not supposed to be with, you can fine the background color on the style guide.

    I hope you fine this helpful

    Marked as helpful
    1
  • Dellenar•160
    @dellenarSubmitted over 1 year ago

    It was challeging with dealing lots of stuff and classes. At start it come as mess to deal with so many variables but at the end i managed to make it trough. I don't know if my code is mess and sure it's not 100% clean but i did my best. As time goes i believe i can make it way more smooth. All i have to do before dive into coding need to plan each section and create common classes for the same variables to make it more clean.

    Please Check out my code and see if you have any advice for me. It's been almost 2 month since i start coding with HTML+CSS. So you can comment me about if i'm at a good point compared to 2 month of study. Thank you in advance ! Also thanks to the Frontendmentor to provide us such challenges to improve ourselves

    Fylo-Landing-Page HTML+CSS

    2
    Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    I must say you did a wonder job their, main look that the solution it look as if you use css flame works but you did it with pure css nice work their, i really love layout.

    continue the good works bro, no cap, you did a really things their,

    i hope you find this comment more encouraging and helpful

    Marked as helpful
    1
  • Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    I have other recommendations regarding your code that I believe will be of great interest to you. CSS: I WILL LIKE TO GO STRAIGHT TO THE POINT your images look more of white you can correct this by making the background color of the image div purple and then apply this property to the div: "background-blend-mode: multiple;"

    secondly, your image shrink with the whole card, i took a look that your code an saw that your use the source tag to set you image media quire, that good acually but you have to use only one instead of setting two source code at your picture tag

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Marked as helpful
    1
  • Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    I have other recommendations regarding your code that I believe will be of great interest to you. CSS: I WILL LIKE TO GO STRAIGHT TO THE POINT your images look more of white you can correct this by making the background color of the image div purple and then apply this property to the div:

    "background-blend-mode: multiple;"

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Marked as helpful
    0
  • Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hey, Hey, I think the reason why your image is not showing up is because it's not being linked correctly. You have the file path as : /images/image-qr-code It should be: ./images/image-qr-code. The problem is that you didn't add . That is full stop to the from Try it out :)

    0
  • sorin7345•50
    @sorin7345Submitted over 1 year ago

    Hello, World! :)

    My main problem solving this challenge was the shade that appears over the picture on the right side, any solution would be much appreciated :D.

    Of course, any piece of advice or feedback is welcomed as to how I could improve certain aspects in writing my own code. Thanks to anyone willing to spare a few moments to leave a short recommendation or advice.

    As always, big thumbs up for the community :)

    Stats-preview-card-component-using-basic-HTML-and-CSS

    2
    Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hi sorin7345, Congratulations 👏👏 on completing your project, I like the position your layout. Ok about the purple 💜 color that fade on the pic, you can actually do that by add background color to the tag that wrapped the picture then you add this css property "background-blend-mode: multiple" to that same tag.

    I hope you fine this helpful

    0
  • Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hi Generoustechnocrat, Congratulations on completing your project, you did very well in the layout but the width you give to you container, is too small because you only set the property to width instead of max-width and you gave the image a width of some number I can't remember, I suggest you set the width of your image to 100% so it will complete cover your items container.

    I hope you fine this useful

    Marked as helpful
    0
  • Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hi James, Congratulations on completing your project, I see you image is not show because you didn't direct your url to the place where the image can, I should say you should try to abjust that. To ../images/ name of the image, if you are using vs studio the images will pop up when you do that and then you select the image. Secondly you used <b> tag to make your button, I guess that's is the wrong path, use the button tag to do that.

    I hope you find This helpful

    Marked as helpful
    0
  • Emmanuel Akpan•790
    @heisemmaco-devPosted over 1 year ago

    Hi Erick384, Congratulations on completing your front mentor project, I love your how you layout but you add height "100%" in your image that why you image doesn't look nice, I will always prefer you don't use height on images and also you didn't use the right font family, you can see that right to use on the style-guild.md on the file provided for you.

    I hope this will be helpful

    0