CSS FLEX - MEDIA QUERIES

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • The section element is not meant to use here, because it cannot define landmark of a webpage

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <section class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Yeifren Palacios•20

  @Yeiifrensk8Posted over 1 year ago

  Hello Abdul, thank you very much for taking the time to review my code, I find it very useful and excellent information that you provide me. I will keep it in mind and I will try to put it into practice more often in order to get used to using more semantic code in a better way. Thanks again, regards. @0xAbdulKhalid

  0
• 

  Emmanuel Akpan•790

  @heisemmaco-devPosted over 1 year ago

  Hi Yeiifrensk, Great work right their, I love the responsiveness of the card but on Mobil and desktop but their is one thing you you missed the background color, the background color is not supposed to be with, you can fine the background color on the style guide.

  I hope you fine this helpful

  Marked as helpful

  1

  ---

  

  Yeifren Palacios•20

  @Yeiifrensk8Posted over 1 year ago

  Hi Emmanuel, thanks for taking the time to review my code. And yes, clearly ignore the background color. I am really something new in this and I must adjust to the way of solving the exercises, since I did it only with the naked eye. Thanks again, regards. @Moderateemmaco

  1