Order- Summary-Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Use font sizes with em and rem, not in pixels, because pixels do not adapt to the browser's font size. For media query breakpoints, you can use em exclusively.

  • Some images do not have a description in the alt attribute. For example, the icon image may have an empty alt attribute alt="" because this image is for decorative purposes and does not add anything to the content of the page.

  • "Proceed to Payment" and "Cancel Order" should be interactive elements (buttons, links, etc.) and not a div or a paragraph. If an element has a cursor: pointer, it means that the user can interact with the element.

  • "Order Summary" should be a heading and not a paragraph.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1

  ---

  

  JustMe__Dev•140

  @Olagunju9148Posted over 1 year ago

  @MelvinAguilar thanks for these tips....the Order Summary was paragraph, I ran into some issues. These made me changes it to paragraph.

  1
• 

  Emmanuel Akpan•790

  @heisemmaco-devPosted over 1 year ago

  Hi Olagunju, Congratulations on completing your first frontend mentor challenge, you did everything well but you page is not responsive on a mobile device this is because you add min-width in your media quire and you didn't direct your flex to column in your real body

  Marked as helpful

  0

  ---

  

  JustMe__Dev•140

  @Olagunju9148Posted over 1 year ago

  @Moderateemmaco without the min width, it'll not be ohk at all on Mobiles. I'll try applying the flex direction

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1