Hi everyone,
I would like to know if it's a good approach to hide the medium hero image in the desktop with display none, to add it again in the medium and small view, thank you.
Hi everyone,
I would like to know if it's a good approach to hide the medium hero image in the desktop with display none, to add it again in the medium and small view, thank you.
Hey, congratulations on completing the challenge. I've noticed a problem in the footer background image. It repeated, so to fix that
footer { background-size: cover; background-repeat: no-repeat; background-position: center center; }
I hope this will help.
Dear members,
It is the second submission for this challenge because the first one had a few bugs which is removed in the solution. The code is improved based on the comment on the previous solution.
Kindly comment on your idea about this submission.
Thanks & regards,
Khalil
Congratulation on completing the challenge.
In terms of accessibility issues simply wrap all your content between main tags.
Instead of an a tag, I recommend wrapping your img tag in a div tag.
<div class="image-wrapper"> <img class="ntf-img" src="./images/image-equilibrium.jpg" alt=""> </div>
Happy Coding!!
Kind of weird process for me. Especially the image portion but the rest was alright.
Your solution is fantastic, but I believe you should change the background-blend-mode to overlay to match the design.
I couldn't make the images in the cards to show behind the blue background, would very mush appreciate if anyone can teach me how to
good job completing the challenge!
to fix the issue,
.card .data { position: relative; z-index: 4; }
You do this because you set the z-index: 3 of the class icon and must set position relative because the z-index has no effect on the element if it is not positioned.
i think this will help!
Hello - I'd like feedback on how i could better vertically center the "per month" copy next to "$29" under "Monthly Subscription"? How have others written the html markup? I used a paragraph tag to contain that sentence but maybe i should use another tag instead Feedback is welcome Thanks
hi Andrew Saganda, good job completing this challenge
in terms of accessibility issues simply wrap all content between main tag and you should have one level one heading h1 tag
keep up the good work...!
Hey good job completing this challenge
Keep up the good work
to prevent overflow on smaller screens set media query max-width greater than card's width like this
@media screen and (max-width: 650px) {...}
In terms of accessibility issues simply wrap all your content between main tags
I hope this helps
I'm having a problem with the social icon and the background, and I'd appreciate it if someone could shed some light on it.
Hey good job completing this challenge!
to fix background use background-size.
body { background-size: cover; min-height: 100vh; }
or shorthand
body { background: url("./images/bg-desktop.svg") no-repeat center/cover; }
and, in accordance with the style guide, the background should be hsl(257, 40%, 49%).
for social icons use fontawesome
in terms of accessibility issues simply wrap all your content between main tags
keep up the good work...!
any feedback please?
Hey good job completing this challenge
Keep up the good work
In terms of accessibility issues, simply wrap section tags with main tags.
I hope this helps
Other than that, the solution looks amazing.
Hello,
Would love some feedback on the project.
I was wondering what are some other ways to change the color of a svg when hovering over it? I did it now using Filter(), but i think it is more grey then white.
congratulation on completing the challenge
use fill attribute to change the hover color
<svg class="icon"> <path d="M20 2.172a8.192 ......." fill="#fff" fill-rule="nonzero"/> </svg>
inside css
.icon:hover {
fill: "#000"
}
Could anyone help me with aligning the svgs to the the center in relation to the text to the right of them? As always if you see other areas of improvement feedback is welcome!
congratulation on completing the challenge. to align the svg with the text, use display flex and align items center.
.flex-item { display: flex; align-items: center; } .cyan { margin-left: 8px; }
try not to use height instead use min-height
body { min-height: 100vh; }
This is my finished project. Can someone explain me why the 2 images that should be on the background, doesn't show up?
Thank you in advance!
congratulation on completing the challenge.
your CSS file locate in the dict file so in this case if you want to access the image file you want to go to the parent directory like this
../images/###
body { background-image: url(../images/bg-pattern-top.svg), url(../images/bg-pattern-bottom.svg); }
./ represent current directory
I made it with flexbox... Can't put it on the center of the page. And it's seem to be an error with loading images
to put the container middle on the screen try this
body { display: flex; justify-content: center; align-items: center; min-height: 100vh; }
.contenair { display: flex; flex-direction: row; }
flexbox CSS-TRICK - a complete guide to flexbox
Keep up the good work!!