Meet landing page

Community feedback

• 

  T.Praveen•870

  @gwtpraveenPosted about 2 years ago

  Hey, congratulations on completing the challenge. I've noticed a problem in the footer background image. It repeated, so to fix that

  footer {
      background-size: cover;
      background-repeat: no-repeat;
      background-position: center center;
  }
  

  I hope this will help.

  Marked as helpful

  0

  ---

  

  kellyc•140

  @kelly1801Posted about 2 years ago

  @gwtpraveen thank you for you feedback it's totally helpful

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Kellyc, congratulations for your new solution!

  I think was a good approach the way you did to swap the images, another alternative as inserting these images inside the picture tag and settting in the html when the images should change between devices, I think is the best way since you don't even need to se a media query since you can do everything inside the html.

  If you don't know this tag and this approach yet is something you should try for sure in this or in future challenges, here's the guide to use it: https://www.w3schools.com/tags/tag_picture.asp

  👋 I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  kellyc•140

  @kelly1801Posted about 2 years ago

  @correlucas thank you! I didn't know about the picture tag

  1