@gumrahsindar
@cocotiwak
Submitted
First time using grid. Little bit confusing, especially when combine with Tailwind. But there's always first time for everything :)
And, still struggle to understand how to create the mobile drop-down list.
But, yeah, this is my solution right now. Any feedback Guys ? thanks in advanced.
@gumrahsindar
Posted
Hi 👋 A short time ago, I'd completed this challenge too with Tailwind CSS. I suggest that you should compare your solution with mine. It will be very useful. (If you don't know React, you can use browser dev tool). Happy coding 👊
@Jey223
Submitted
All reviews are needed to help me get better
@gumrahsindar
Posted
Hi there 👋 Users should be able to switch the button when they click outside the circle. You should consider fixing that.
Marked as helpful
@mbdelarosa
Submitted
Hello! Just wanted to know if my usage of the section tag here is appropriate?
Any other feedback is also welcome, thank you!
@gumrahsindar
Posted
The decision is completely up to you, but the main convention is to use <header> <main> and <footer> (if any). After that, you can organize your main area with different <section>, <article> or <aside> tags. It both effects accessibility and SEO. Also I recommend to read this: Document and website structure
Marked as helpful
@mbdelarosa
Submitted
Hello! Just wanted to know if my usage of the section tag here is appropriate?
Any other feedback is also welcome, thank you!
@gumrahsindar
Posted
Hi there 👋 You can use two sections. One for hero f.e. <section id='hero'> and one for cards f.e. <section id='cards'>
@fisaavedrae
Submitted
@gumrahsindar
Posted
Hi there 👋 To fix background image problem, both mobile and desktop version you can do these:
background-size: contain;background-size: cover; and height: 100vh;After that, you will see that bg image issue fixed. 👊
Marked as helpful
@tavishnew
Submitted
Any suggestions related to the display responsiveness would be helpful...
@gumrahsindar
Posted
Hi 👋
background-color property from main and add it to body. Thus, you can fill the light gray color to the whole page.margin: 5rem auto to body selector to ensure desired result.grid or flexbox for smooth responsiveness instead of relative/absolute etc. (my suggestion is Grid, btw.)Apart from these, it's looking good. Well done 👊
Marked as helpful
@SteellWater
Submitted
@gumrahsindar
Posted
Hi 👋
Here are my suggestions:
To fix the over-extended bottom white area, you should remove the height: 100vh property from the CSS selector of the body element.
Consider using rem instead of % for margin and padding declarations.
Apart from these, it's looking good. Keep working. :)
Marked as helpful
@Huguedes
Submitted
@gumrahsindar
Posted
Hi Hugo 🙋♂️. Firstly, congrats for your first challenge like me. I have a few little suggestions regarding appearance:
Thats all, happy coding 👋
