Card QR code responsive

Community feedback

• 

  P

  Gümrah Sindar•490

  @gumrahsindarPosted over 1 year ago

  Hi Hugo 🙋‍♂️. Firstly, congrats for your first challenge like me. I have a few little suggestions regarding appearance:

  • You can increase width of main card container. Yours is a little narrower than the original one.
  • You can decrease the padding between image and main container. There is noticeably more space between them.
  • You can add much padding-bottom to <p> tag.

  Thats all, happy coding 👋

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • Your solution generates accessibility error reports due to non-semantic markup

  ---

  • So fix it by replacing the <div class="principle"> with semantic element <main> and <div class="attribution"> with element <footer> to improve accessibility and organization of your page.

  ---

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections

  ---

  I hope you find it helpful ! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1