normal css layout using padding to get around margin collision

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The width: 100% property for body element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  SteellWater•30

  @SteellWaterPosted over 1 year ago

  @0xAbdulKhalid Sorry that I am answering just now, I didn't log since. Indeed I have that same problem on mobile but I will take that in account and correct it. Thansk you were a great help.

  0
• 

  P

  Gümrah Sindar•490

  @gumrahsindarPosted over 1 year ago

  Hi 👋

  Here are my suggestions:

  • To fix the over-extended bottom white area, you should remove the height: 100vh property from the CSS selector of the body element.

  • Consider using rem instead of % for margin and padding declarations.

  Apart from these, it's looking good. Keep working. :)

  Marked as helpful

  1

  ---

  

  SteellWater•30

  @SteellWaterPosted over 1 year ago

  @gumrahsindar Hi Thanks for your suggestions. I will try using rem and see if it fits me best. I used % because I wanted the maintain the same proportions whether the screen size, but it seems that I can attend the same result with rem. If you have other tips, I am taking them. Thanks again for your help!

  0