kirankumar636164• 30
@kirankumar636164
Submitted
Gabriel Gasperi Casagrande
@gabrielcasag
All comments
@gabrielcasag
Posted
Hi @kirankumar636164, good job! i suggest you to use the tag <a> for the social media links, since they are a link to another site, also suggets you to reset the default css for better styling control!
0- FirstHalcyon• 40
@FirstHalcyon
Submitted
What are you most proud of, and what would you do differently next time?
Big thanks to @Stroudy for their feedback on my last project. Tried to apply as much of it as I could.
Really happy with how this one turned out. Tried to avoid divs as much as possible, just to see what other html tags had to offer. Still unsure if I used them correctly, however. Avoided pixels too.
What challenges did you encounter, and how did you overcome them?
I learned many new tricks since my first project, so trying to understand and apply all of them definitely took a while. I love Flex, but sometimes I can't get it to play nice. Guess I need to practice more with spacing and measurements.
What specific areas of your project would you like help with?
Mostly the html tags. It's my first time using them, so I'm not too sure if I did my best with them.
@gabrielcasag
Posted
incredible work, congrats! my only observation is that I noticed that you used rem for all the spacings but only the border-radius it is in px, is there any reason behind this?
1 @edwincaipa
Submitted
@gabrielcasag
Posted
the layout is almost perfect, with the exception that the spacing below the descriptive text became larger than necessary when adding the card padding (16px) with the paragraph margin-bottom (40px).
Regarding the code, there is room for some improvements, such as using the sr_only class when you want to hide an element on the screen. and also the code mixes px with rem in the spacing, the ideal would be to use just one unit of measurement
Marked as helpful
0
