Fernando Valdés García
@fvaldes0109All comments
- @iyanez2314Submitted over 1 year ago@fvaldes0109Posted over 1 year ago
Hi, nice work! Just some small suggestions. Try adding
min-height: 100vh
to your body styles in order to vertically center the card. Also the elements with an active state (the button), should have acursor: pointer
. And finally, if you want to get both prices centered along the x axis, try adding:.perfume-price { display: flex; align-items: center; }
1 - @fvaldes0109Submitted about 3 years ago
Any suggestion is welcome
@fvaldes0109Posted about 3 years agoThanks! That's a really nice way of centering the card
0 - @Ace953Submitted about 3 years ago
Hello everyone! Please give me your feedback and let me know if you would make any change. Thank you :)
@fvaldes0109Posted about 3 years agoYou should remove the
overflow: hidden
property from the body, since on smaller screens the bottom part of the page is being cut off, and mobile views this is a bigger issueMarked as helpful1 - @OscarandioSubmitted about 3 years ago
I feel very proud of this one. The only thing I am not able to figure out is how I can set the background exactly the same as the preview. I guess I need to repeat the picture and put it in the opposite side, mirroring or something. I am not sure, so any advice about it is welcome! Thanks
@fvaldes0109Posted about 3 years agoThere are two background photos at the resources, for top and bottom. You can try creating two
img
elements. Setbg-pattern-top.svg
as thesrc
of the firstimg
, andbg-pattern-bottom.svg
as thesrc
of the second one. Also bothimg
s must be set withposition: absolute
, so you can move them freely and they won't mess with the card. With that you can just experiment moving around each image with thetop
,left
,right
andbottom
properties until you get the design you want.1 - @ferhammarenSubmitted about 3 years ago
I would like some tips on how to keep the design looking proportional when doing larger resolutions, as anything above w1440 looks too spread out and i'm not sure if that's the best solution. Any comments or things i can change or make better would be greatly appreciated!
@fvaldes0109Posted about 3 years agoTry readjusting the "music icon / anual plan / change" part. Something like set its container centered and with a smaller fixed width. Also try to
float: left
the icon and the text, andfloat: right
the 'change'. Hope it helps0