social proof section

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Ace953 👋🏻

  I have some quick tips to help you fix the accessibility issues and some other things.

  • First, in your markup, <div class="wrapper">...</div> should be <main class="wrapper">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
  • For the star icons, add aria-hidden="true”, because they're for decoration. You can read more about aria-hidden here.
  • Also, add min-height: 100vh to body so the background-image can stretch all the way down.
  • Lastly, as already suggested, remove overflow: hidden; otherwise, the user can only see the half of the content.

  I hope this was helpful 👨🏻‍💻 Other than that, you did a great good job, nicely done. Cheers 👾

  Marked as helpful

  1

  ---

  

  Ace953•60

  @Ace953Posted about 3 years ago

  @kens-visuals Thank you very much for your feedback, it was very helpful. I've applied your corrections. Now you are able to see the mobile version as well. I first put the property overflow: hidden to delete the vertical scrollbar. How can I remove it?

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @Ace953 you should have a vertical scrolling, without scrolling we won't be able to see the content, and there's too much content to fit on a screen without scrolling.

  Marked as helpful

  1
• 

  Fernando Valdés García•415

  @fvaldes0109Posted about 3 years ago

  You should remove the overflow: hidden property from the body, since on smaller screens the bottom part of the page is being cut off, and mobile views this is a bigger issue

  Marked as helpful

  1

  ---

  

  Ace953•60

  @Ace953Posted about 3 years ago

  @fvaldes0109 Thanks for the tip, now you can see also the mobile design :) I put ´overflow: hidden´ trying to delete the vertical scrollbar. How would you suggest to remove it?

  0

  

  Fernando Valdés García•415

  @fvaldes0109Posted about 3 years ago

  @Ace953 I think you should leave the scrollbar. As @kens-visuals said there is too much content to display on a fixed view. If you try compressing it to fit the screen you'll be sacrificing visual quality, or the content may become too small for reading.

  Marked as helpful

  1