JeremyWarui• 250
@JeremyWarui
Submitted
I took only a few hours to do this challenge. It was good I enjoyed the flex-box (you can notice by how much i have used it).
Looking forward to growing more.
Anthony Oyathelemhi
@frontendtony
All comments
@frontendtony
Posted
Fine work Jeremy!
A few things that could be better:
- The wavy background images don't cover the entire width on large displays. You can fix this by adding
background-size: containright after thebackground-imagedeclaration. - The "hero-text" is not supposed to grow beyond a certain point. You should add
max-width: 60chto the style to correct this. See here for howchworks - "screen mock ups" image should have a width and height. Use the values you can see on Figma. See here to understand why this is a good practice
Marked as helpful
0- The wavy background images don't cover the entire width on large displays. You can fix this by adding
- ThanhVuong0904• 465
@ThanhVuong0904
Submitted
This is my first time using SCSS. Hope you like this solution. Please tell me if there is something to improve in my code. Thanks you!
@frontendtony
Posted
Design implementation in on point 👌🏽
Looking at your markup however, I noticed a pattern that you could work on improving.
- Use semantic HTML markup. For example 'Why choose Easybank?' should be a
h2tag, not adiv. - Use less markup. There are lots of unnecessary nested
divtags where just one could've worked. In each sections, you used 3 'wrapper' tags, you could've applied styles on just one to achieve the same thing - Use the
altattributes in yourimgtags to describe the image to visually-impaired users
Marked as helpful
0 - Use semantic HTML markup. For example 'Why choose Easybank?' should be a
- abdallah akrab• 50
@akrabdev
Submitted
Is there a way to make good looks better on mobile without using media queries?
@frontendtony
Posted
The colors look a bit different from the design, including the button background and text colors. Other than that, it looks pretty close to the design visually. Good job
0
