Skip to content
OverviewSolutions
2
Comments
3
Anthony Oyathelemhi
@frontendtony

All comments

  • JeremyWarui•250
    @JeremyWaruiSubmitted about 3 years ago

    I took only a few hours to do this challenge. It was good I enjoyed the flex-box (you can notice by how much i have used it).

    Looking forward to growing more.

    Huddle Site Challenge: Using Flexbox

    1
    Anthony Oyathelemhi•75
    @frontendtonyPosted about 3 years ago

    Fine work Jeremy!

    A few things that could be better:

    • The wavy background images don't cover the entire width on large displays. You can fix this by adding background-size: contain right after the background-image declaration.
    • The "hero-text" is not supposed to grow beyond a certain point. You should add max-width: 60ch to the style to correct this. See here for how ch works
    • "screen mock ups" image should have a width and height. Use the values you can see on Figma. See here to understand why this is a good practice
    Marked as helpful
    0
  • ThanhVuong0904•465
    @ThanhVuong0904Submitted about 3 years ago

    This is my first time using SCSS. Hope you like this solution. Please tell me if there is something to improve in my code. Thanks you!

    HTM5, SCSS, JS

    2
    Anthony Oyathelemhi•75
    @frontendtonyPosted about 3 years ago

    Design implementation in on point 👌🏽

    Looking at your markup however, I noticed a pattern that you could work on improving.

    1. Use semantic HTML markup. For example 'Why choose Easybank?' should be a h2 tag, not a div.
    2. Use less markup. There are lots of unnecessary nested div tags where just one could've worked. In each sections, you used 3 'wrapper' tags, you could've applied styles on just one to achieve the same thing
    3. Use the alt attributes in your img tags to describe the image to visually-impaired users
    Marked as helpful
    0
  • Anthony Oyathelemhi•75
    @frontendtonyPosted about 3 years ago

    The colors look a bit different from the design, including the button background and text colors. Other than that, it looks pretty close to the design visually. Good job

    0