Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTM5, SCSS, JS

ThanhVuong0904β€’ 465

@ThanhVuong0904

Desktop design screenshot for the Easybank landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my first time using SCSS. Hope you like this solution. Please tell me if there is something to improve in my code. Thanks you!

Community feedback

@frontendtony

Posted

Design implementation in on point πŸ‘ŒπŸ½

Looking at your markup however, I noticed a pattern that you could work on improving.

  1. Use semantic HTML markup. For example 'Why choose Easybank?' should be a h2 tag, not a div.
  2. Use less markup. There are lots of unnecessary nested div tags where just one could've worked. In each sections, you used 3 'wrapper' tags, you could've applied styles on just one to achieve the same thing
  3. Use the alt attributes in your img tags to describe the image to visually-impaired users

Marked as helpful

0

ThanhVuong0904β€’ 465

@ThanhVuong0904

Posted

@frontendtony Hi thanks you,

  1. I know it but I don't know why I do it.

  2. I'm little confused at banner section.

0
Tesla_Ambassadorβ€’ 3,000

@tesla-ambassador

Posted

This is really awesome! You might want to consider using a class of header like elements instead of using headers to avoid the html issues otherwise, I think this is really great work! kudos

Marked as helpful

0

ThanhVuong0904β€’ 465

@ThanhVuong0904

Posted

@tesla-ambassador Yeahh! Thanks you for feedback.

1
Tesla_Ambassadorβ€’ 3,000

@tesla-ambassador

Posted

@boypro0409 No problem!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord