HTM5, SCSS, JS

Community feedback

• 

  Anthony Oyathelemhi•75

  @frontendtonyPosted about 3 years ago

  Design implementation in on point 👌🏽

  Looking at your markup however, I noticed a pattern that you could work on improving.

  1. Use semantic HTML markup. For example 'Why choose Easybank?' should be a h2 tag, not a div.
  2. Use less markup. There are lots of unnecessary nested div tags where just one could've worked. In each sections, you used 3 'wrapper' tags, you could've applied styles on just one to achieve the same thing
  3. Use the alt attributes in your img tags to describe the image to visually-impaired users

  Marked as helpful

  0

  ---

  

  ThanhVuong0904•465

  @ThanhVuong0904Posted about 3 years ago

  @frontendtony Hi thanks you,

  1. I know it but I don't know why I do it.

  2. I'm little confused at banner section.

  0
• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  This is really awesome! You might want to consider using a class of header like elements instead of using headers to avoid the html issues otherwise, I think this is really great work! kudos

  Marked as helpful

  0

  ---

  

  ThanhVuong0904•465

  @ThanhVuong0904Posted about 3 years ago

  @tesla-ambassador Yeahh! Thanks you for feedback.

  1

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  @boypro0409 No problem!

  0