Design comparison
SolutionDesign
Solution retrospective
I took only a few hours to do this challenge. It was good I enjoyed the flex-box (you can notice by how much i have used it).
Looking forward to growing more.
Community feedback
- @frontendtonyPosted about 3 years ago
Fine work Jeremy!
A few things that could be better:
- The wavy background images don't cover the entire width on large displays. You can fix this by adding
background-size: contain
right after thebackground-image
declaration. - The "hero-text" is not supposed to grow beyond a certain point. You should add
max-width: 60ch
to the style to correct this. See here for howch
works - "screen mock ups" image should have a width and height. Use the values you can see on Figma. See here to understand why this is a good practice
Marked as helpful0@JeremyWaruiPosted about 3 years ago@frontendtony Thanks Anthony!
First time to hear "ch".
Taking notes! Thanks.0 - The wavy background images don't cover the entire width on large displays. You can fix this by adding
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord