Can you please check if this meets all the requirements ? Also, suggestions for improvement, alternate ideas are welcome and very much appreciated. Thanks in advance.
Nice work. Did you forget to add your images directory? i can't see the background image there. Suggestion from me, i think you can styling the button when user clicked, so the user know what are they doing;
First of all, nice work ππ». Congratulations on finish this challange. π
I have some suggestions on your solution.
do you forget to check your image source? You should use alt="./your-icon.svg" instead of ./images/your-icon.svg. Because there isn't directory named images in your repository.
to solve accessibility issues, you can change your <div class="container">...</div> to <main class="container">...</main>. And you can change your <div class="attribution">...</div> to <footer class="attribution">...</footer>
I hope my sugesstions can help you, have a nice day and happy coding ππ»
First of all, nice work. Congratulations on finishing this challange. π
I want to give some sugesstions that i hope can help you to the next level.
I have issues when show site in mobile screen, there is an overflow problem. After trying to resolve that, width and height which is set 100% on html style should be removed. And instead using height 100vh in body style, it should changed to min-height 100vh. (or you can use fixed background-attachment)
I suggest to using link <a> only when linking to another page or only when redirect to a particular section on the same page
as in the style guide, font-family need set to Kumbh Sans, sans-serif.