HTML, CSS, JS, GRID, Mobile first workflow

Community feedback

• 

  Faruq Abdul Hakim•580

  @faruqAbdulHakimPosted almost 3 years ago

  First of all, nice work. Congratulations on finishing this challange. 🎉

  I want to give some sugesstions that i hope can help you to the next level.

  • I have issues when show site in mobile screen, there is an overflow problem. After trying to resolve that, width and height which is set 100% on html style should be removed. And instead using height 100vh in body style, it should changed to min-height 100vh. (or you can use fixed background-attachment)

  • I suggest to using link <a> only when linking to another page or only when redirect to a particular section on the same page

  • as in the style guide, font-family need set to Kumbh Sans, sans-serif.

  happy coding ^^

  Marked as helpful

  0

  ---

  

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  @faruqAbdulHakim Thank you very much for taking time to look into my solution. I will implement your suggestions shortly.

  0

  

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  @faruqAbdulHakim I have implemented the changes you suggested. Works like charm. Thank you.

  Also, this time I used all the 3 images for desktop, and fixed some other problems.

  1
• 

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  P.S: I found some problems with image position after commit. Now it looks much closer the design and better the screenshot.

  0