3-column-component

Community feedback

• 

  Faruq Abdul Hakim•580

  @faruqAbdulHakimPosted almost 3 years ago

  First of all, nice work 👏🏻. Congratulations on finish this challange. 😄 I have some suggestions on your solution.

  • do you forget to check your image source? You should use alt="./your-icon.svg" instead of ./images/your-icon.svg. Because there isn't directory named images in your repository.
  • to solve accessibility issues, you can change your <div class="container">...</div> to <main class="container">...</main>. And you can change your <div class="attribution">...</div> to <footer class="attribution">...</footer>

  I hope my sugesstions can help you, have a nice day and happy coding 👋🏻

  0