@Mikkybeardless
Submitted
made changes to make it semantic. check it out, any advice is welcomed
@evengene
@Mikkybeardless
Submitted
made changes to make it semantic. check it out, any advice is welcomed
@evengene
Posted
Hello @Mikkybeardless, congratulations on completing the project!
Here are several items I noticed that can help:
index.css
and App.css
files but you can consolidate them into one file;index.css
line 24, should be font-size: 12px;
Our multifunctional collection....
<Slide 1>, <Slide 2> ...
seems to be the same component with different text - maybe you can render one with different props?openHarmburger
;) , CaroselBtn (CarouselBtn)
CaroselBtn.tsx
is not used anywhereThank you and good luck!!
@sobbaka
Submitted
Technologies used
Description
The multi-page space tourism website. This project is an adaptive website created using HTML, CSS and JS. It features a responsive design that works well on a variety of devices, from desktops to smartphones.
The website has been built using the BEM methodology. Swiper librabry was used to build responsive and touch sliders.
@evengene
Posted
hey Aleksandr Bagaev, good job on the project. Couple of ideas to add on:
Thank you and good luck in your future projects.
@Bkevin3110
Submitted
My css is pretty messy. If anyone has time to comb through it and make suggestions how to clean it up bettter that would be great!
Javascript was pretty new but got the hang of it. Wasn't sure if I should've some how looped through the data or setting it to variables was okay.
Also I don't know any standard best practices let me know if there's a link to any.
@evengene
Posted
Hello @Bkevin3110, Good job on the project. Here are several things I think you can improve in your codebase.
Overall I would advise to use a linter to cover a basic code formatting, try using Free Online CSS Beautifier / Formatter for example for your *.css and *.html files.
style.css
index.html
<h3>Summary</h3>
README.md
I also think the “Continue” button has a border that design does not have, feel free to check it as well.
Great job and good luck!
Marked as helpful