Submitted 10 months ago
semantic room home page, built with react typscript and tailwind css
@Mikkybeardless
Design comparison
SolutionDesign
Solution retrospective
made changes to make it semantic. check it out, any advice is welcomed
Community feedback
- @evengenePosted 10 months ago
Hello @Mikkybeardless, congratulations on completing the project!
Here are several items I noticed that can help:
- The page looks great on responsive devices like desktop (1440px) and smaller, but try resizing the window for larger devices both width and height and you notice it has some blank space;
- You have both
index.css
andApp.css
files but you can consolidate them into one file; - Linting error in
index.css
line 24, should befont-size: 12px;
- 2 Spelling issues in this paragraph:
Our multifunctional collection....
<Slide 1>, <Slide 2> ...
seems to be the same component with different text - maybe you can render one with different props?- Spelling in
openHarmburger
;) ,CaroselBtn (CarouselBtn)
- Look slike
CaroselBtn.tsx
is not used anywhere
Thank you and good luck!!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord