Results page with Javascript for data and events

Community feedback

• 

  P

  Elina Shelest•150

  @evengenePosted about 1 year ago

  Hello @Bkevin3110, Good job on the project. Here are several things I think you can improve in your codebase.

  Overall I would advise to use a linter to cover a basic code formatting, try using Free Online CSS Beautifier / Formatter for example for your *.css and *.html files.

  style.css

  • try avoiding naming the classes with a capital letter ( for ex: “.Summary ”)
  • line 147, 148 contains error - should be “24px”
  • please try to cleanup the unused comments like ‘/*https://stackoverflow …’

  index.html

  • feel free to format this file as well
  • there is an error with missing tag on line 37: <h3>Summary</h3>

  README.md

  • you can edit this file to include only info you need for your portfolio, for example you can remove: “Note: Delete this note and update the table of contents based on what sections you keep”

  I also think the “Continue” button has a border that design does not have, feel free to check it as well.

  Great job and good luck!

  Marked as helpful

  0

  ---

  

  Bkevin3110•20

  @Bkevin3110Posted about 1 year ago

  @evengene

  Thank you for the advice! I didnt know about the linter for code formatting! I will go over and fix things you suggested!

  0
• 

  eshrak•120

  @EshrakRahmanPosted about 1 year ago

  I love your design! The way you've added those boxes around the elements looks fantastic. Today, I learned something new from your work. Keep it up, you're doing a great job! 😊

  0