Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found

Submitted

Results page with Javascript for data and events

@Bkevin3110

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My css is pretty messy. If anyone has time to comb through it and make suggestions how to clean it up bettter that would be great!

Javascript was pretty new but got the hang of it. Wasn't sure if I should've some how looped through the data or setting it to variables was okay.

Also I don't know any standard best practices let me know if there's a link to any.

Community feedback

P

@evengene

Posted

Hello @Bkevin3110, Good job on the project. Here are several things I think you can improve in your codebase.

Overall I would advise to use a linter to cover a basic code formatting, try using Free Online CSS Beautifier / Formatter for example for your *.css and *.html files.

style.css

  • try avoiding naming the classes with a capital letter ( for ex: “.Summary ”)
  • line 147, 148 contains error - should be “24px”
  • please try to cleanup the unused comments like ‘/*https://stackoverflow …’

index.html

  • feel free to format this file as well
  • there is an error with missing tag on line 37: <h3>Summary</h3>

README.md

  • you can edit this file to include only info you need for your portfolio, for example you can remove: “Note: Delete this note and update the table of contents based on what sections you keep”

I also think the “Continue” button has a border that design does not have, feel free to check it as well.

Great job and good luck!

Marked as helpful

0

@Bkevin3110

Posted

@evengene

Thank you for the advice! I didnt know about the linter for code formatting! I will go over and fix things you suggested!

0
eshrak 120

@EshrakRahman

Posted

I love your design! The way you've added those boxes around the elements looks fantastic. Today, I learned something new from your work. Keep it up, you're doing a great job! 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord