All comments

• 

  eslamwaleed1•20

  @eslamwaleed1Submitted over 1 year ago

  I'd appreciate any feedback (":

  

  HTML - CSS

  2

  40
  

  Elizabeth Sotomayor•230

  @elizabethrsotomayorPosted over 1 year ago

  Your solution looks great! One suggestion I have would be self-hosting your fonts using google-webfonts-helper rather than downloading fonts, which will allow your site to be more stable in case the link doesn't work for whatever reason. Also, you can use an aria-label for the h1 you have rather than making a whole separate class for it. One more thing, I think your main section needs to have a role. See here. I hope this helps!

  Marked as helpful

  1

  This comment has received 2 repliesShow
• 

  dupakarovsky•280

  @dupakarovskySubmitted almost 2 years ago

  Spent more time on this than a care to admit :/

  

  News homepage // [SCSS / Vanilla JS]

  1

  51
  

  Elizabeth Sotomayor•230

  @elizabethrsotomayorPosted almost 2 years ago

  Your solution looks nice! I like the hover effect for the links. I'm not familiar with SCSS but the only things I can think of would be to make the links at the top darker and the "new" link headings bolder. Also maybe make the "read more" link a little bit larger with less margin so everything lines up. Great work!

  0