HTML - CSS

Community feedback

• 

  Thomas Hertog•825

  @thomashertogPosted over 1 year ago

  you may have completed the desktop design, but it is not responsive. I can't see the mobile view of this.

  other than that, you have used absolute positioning for everything (with pixels) that is definitely not how layouting works nowadays. maybe you can try learning some things about flexbox and/or CSS grid to make a new attempt at this challenge.

  your solution is tagged with #accessibility yet you still have <div class="button"> with an svg (for the icon) which is not hidden from assistive tech (as it should be since it's only decorative), and a paragraph for the text, but no <button> element is used...

  Marked as helpful

  1

  ---

  

  eslamwaleed1•20

  @eslamwaleed1Posted over 1 year ago

  Thanks a lot bro! Your feedback really helps. @thomashertog

  0

  

  Thomas Hertog•825

  @thomashertogPosted over 1 year ago

  @eslamwaleed1 don't be hesitant to ask for help in #help on Discord if you have trouble implementing the feedback

  Marked as helpful

  1

  

  eslamwaleed1•20

  @eslamwaleed1Posted over 1 year ago

  Thanks again (": @thomashertog

  0
• 

  Elizabeth Sotomayor•230

  @elizabethrsotomayorPosted over 1 year ago

  Your solution looks great! One suggestion I have would be self-hosting your fonts using google-webfonts-helper rather than downloading fonts, which will allow your site to be more stable in case the link doesn't work for whatever reason. Also, you can use an aria-label for the h1 you have rather than making a whole separate class for it. One more thing, I think your main section needs to have a role. See here. I hope this helps!

  Marked as helpful

  1

  ---

  

  eslamwaleed1•20

  @eslamwaleed1Posted over 1 year ago

  Thank you a lot! Looking forward to consider your suggestions in my next design. @elizabethrsotomayor

  1

  

  eslamwaleed1•20

  @eslamwaleed1Posted over 1 year ago

  Did you mean changing the <main> to <main role="main"> ? @elizabethrsotomayor

  0