I had a lot of trouble with the line in the header. I am curious how other people solved this.
Junior
@ejmabundaAll comments
- @Dejorden94Submitted 11 months ago@ejmabundaPosted 11 months ago
Hi @Dejorden94, regarding the lines, I just set the two background svgs provided as background image to the
<body>
, then used media queries to toggle between the mobile and desktop background.I'm not sure why you decided to hard code the svg path π¬, but great job on the design. Hope this helps.
1 - @ejmabundaSubmitted 11 months ago
My second solution on this platform built with HTML, SASS and JavaScript to toggle the questions.
I wanted to add a transition when the questions are expanding but it looks weird because the margin also needs to be animated. Did anyone also face the same problem?
I appreciate any feedback you might have. π
@ejmabundaPosted 11 months agoHi @TeixeiraCamila, you're correct,
.accordion-content
has no margin, but when the question has expanded the.active
class gets added which adds the margin. So, I removed the margin added by the.active
class and placed inaccordion-content
, and that worked.Your english is good don't worry, and thanks for the taking the time to go through my code. I will try to animate the icon as well.
0 - @AnlperrSubmitted 11 months ago
All feedback is welcomed thank you in advance.
@ejmabundaPosted 11 months agoHi @Anlperr, for semantics, try to avoid
div
s where possible. Instead use semantic elements likesection
,header
etc. For example, usefigure
for thecard-image
, and usesection
for thecard-content
. This improves SEO of your page. Otherwise, the design looks good π π Hope this helps.2 - @ejmabundaSubmitted 11 months ago@ejmabundaPosted 11 months ago
Here's my solution for the blog preview card challenge. Tech stack:
- HTML
- CSS (SASS)
- Git
Feel free to provide any feedback or tips on how I can improve this solution. Thanks.
0 - @AdeMEDIASubmitted 11 months ago
This is my submission for the Blog Card project. The project focuses on creating a responsive and visually appealing card using HTML and CSS.
Features:
- Structured content with semantic HTML elements.
- Design with CSS.
Are there any suggestions for improvements?
I would greatly appreciate any feedback.
Thanks in advance, developers! β€οΈ
@ejmabundaPosted 11 months agoI might be nitpicking, but there's a border around the card which you forgot to add, and the author's name is too close to the avatar. Apart from that, it looks good.
1