Blog card preview

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 10 months ago

  Hello there @Anlperr 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  General Structure and HTML:

  • Consider using <span> or <time> instead of paragraphs for elements that are not actual paragraphs like "Learning" and "Published...".

  CSS and Styling:

  • Implement CSS custom properties to define and utilize project colors more easily.
  • Avoid using px for font-size, you could read this article to learn why. Letter spacing and line height must not be in px, use rem for all the font-related properties.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.
  • Let the content decide the height of the elements. Use padding and margins strategically for this purpose.

  Accessibility and Semantic HTML:

  • The icons/illustration images are decorative, so their alt text must be empty: alt="".
  • Profile image could benefit from a more descriptive alt text, like alt="Headshot of Greg Hooper".

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  2
• 

  abedzeidan•340

  @Abed001Posted 10 months ago

  Nice work on this challenge! A suggestion I have is to add a hover effect on text to turn the text to yellow . and on the card something like this :cardshadow{ box-shadow: 10px 10px rgba(0,0,0);}

  .cardshadow:hover { box-shadow: 15px 15px rgba(0, 0, 0); /* Increase shadow size and opacity on hover */ } . keep going!!

  2
• 

  Junior•40

  @ejmabundaPosted 10 months ago

  Hi @Anlperr, for semantics, try to avoid divs where possible. Instead use semantic elements like section, header etc. For example, use figure for the card-image, and use section for the card-content. This improves SEO of your page. Otherwise, the design looks good 👌 🙌 Hope this helps.

  2