Skip to content
OverviewSolutions
15
Comments
6
Edgar Fernando Britez
@edgarfb

All comments

  • Devika Sujith•175
    @DCoder18Submitted over 2 years ago

    Hey guys, this is my first javascript project here. It was fun to do. The only part I found challenging was the user's ability to add a custom tip. I wasn't sure how I would trigger it since there wasn't a button linked to it in the design. I figured I'd just use the enter key to submit their custom tips. Its not the most efficient or user friendly but I couldn't think of anything else.

    Let me know what approach some of you took and feel free to suggest any improvements :)

    Thanks!

    Tip Calculator with Javascript, HTML, SCSS

    2
    Edgar Fernando Britez•355
    @edgarfbPosted over 2 years ago

    Hi, Davika. It's looking goog! Congrats! I think that you approch if fine because you use just js for this. You have to use some kind of state if you want to use the value that you pass via costo field. Like one variable that manage all the button's values and the input field.

    Issue: >>> If you pass it a non-number value you get a NaN displayed. Check it out.

    Marked as helpful
    1
  • Edgar Fernando Britez•355
    @edgarfbPosted about 3 years ago

    Hi, Juan. Nice work! I think there is a lot space between the cards maybe you can use 4 cards for row.

    Marked as helpful
    0
  • Edgar Fernando Britez•355
    @edgarfbPosted over 3 years ago

    Hello Brenda. You need to centering the content. On my phone there is extra space on the top, and the opposite on my laptop(extra space on the bottom). Hope this help you. Nice work.

    0
  • Joe•80
    @Jcorrales07Submitted over 3 years ago

    Hello every one! :D

    This was fun to make ^^ I would like to have some feedback to improve in my weak areas that you recognize. I would appreciate any advice too!!!

    Can I have any link that teaches me Github please?

    Moblie first HTML CSS AND SASS

    2
    Edgar Fernando Britez•355
    @edgarfbPosted over 3 years ago

    Hi joe. How are you? You can try with Github Labs. https://lab.github.com/

    1
  • Franco•20
    @francoggmSubmitted over 3 years ago

    I'm new to CSS and HTML so I had a lot of difficulties even in this challenge. I was not able to superimpose the image with a color or to center it by grid / flexbox. But I did my best and tried my best. :D

    Newbie challenge of a card

    2
    Edgar Fernando Britez•355
    @edgarfbPosted over 3 years ago

    Hi Franco. I setted a background color property to the image container, and I use a opacity property in the image itself. This way the image mixed with the background color. I hope that this can help you. Keep going!

    0
  • Edgar Fernando Britez•355
    @edgarfbPosted over 3 years ago

    Thanks a lot, Eric.

    0