All comments

• 

  Silo de Menezes•20

  @Silo30Submitted 4 months ago

  What are you most proud of, and what would you do differently next time?

  This was similar to my first challange and i'm happy that much of what i learned during it stick with me during this one. I thought that the shadow of the card would be difficult to make, but to my surprise it was very simple, so that's something i'm happy with.

  What challenges did you encounter, and how did you overcome them?

  The 'Learning' Tag took me some time to figure out how to do properly. Looking back with hindsight, it shouldn't have take me soo long to do it. I'll make sure to remember this in future challanges.

  What specific areas of your project would you like help with?

  my styling could be a bit more organized. I think i could have made it shorter and easier for other people to understand it. If anyone see any area for improvement, I'm open ears.

  

  Blog Preview Card made with HTML and CSS in VSCode

  1

  50
  

  deux-trios•40

  @deux-triosPosted 4 months ago

  Design:

  1. At first glance the colour of the main card container should be white, and the scale is bigger than the original design but it's a nitpick
  2. Overall the design is 1 to 1. Good job
  3. The scale of the card shrinks when you zoom out. It would be great if it's static so the content can be seen by people who don't know that the their browser is zoomed out
  4. The layout is good on every screen size

  HTML

  1. I don't like the spaces between the code.
  2. I also don't like how the <footer> tag is indented. I think it's on par with main since they are both landmark elements

  Overall The solution doesn't go too far from the design. I give it a 8/10

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Roman•20

  @whznotSubmitted 5 months ago

  What specific areas of your project would you like help with?

  PIease! Help me out with the responsiveness and code correctness.

  • on the mobile version:

  1. the bottom text goes on the form.
  2. edge margins are not observed.

  • the form itself:

  1. does not observe correct indentation (from photo, text) and I don't know how to fix it and make the code cleaner.

  

  QR Code Component

  1

  20
  

  deux-trios•40

  @deux-triosPosted 4 months ago

  CSS

  1. the margin and padding properties are redundant since you declared flexbox
  2. Everything else is right

  HTML

  • HTML code is right. No glaring errors.

  I learned one thing from this code is that you have to wrap your texts in a div to make it compact and cleaner. Thank you One nitpick that I have is the padding on the texts are big, and the QR code is larger than the original design.

  9/10

  0